fix - MSTeamsV2 config #7352
Merged
fix - MSTeamsV2 config #7352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @simonpasquier I'm trying to understand why ScrapeConfigDNSSD test is failing as it seems unrelated to the changes, don't seem to get a lot of info from the logs, if you have any ideia what might be the issue would be great. |
1 task
rebase your branch it should be fixed now |
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
heliapb
force-pushed
the
fix/msteamsv2_config_r0_80
branch
from
a3fbd56 to
53b60e1
Compare
|
Hi @slashpai thanks, rebase done |
nicolastakashi
approved these changes
Feb 18, 2025
slashpai
approved these changes
Feb 19, 2025
|
Just tested it with operator version 0.80.1 and it works nicely :-) Thanks @heliapb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From issue #7346
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.