Skip to content

chore: refactor labels/annotations CLI flags#5683

Merged
ArthurSens merged 1 commit into
prometheus-operator:mainfrom
simonpasquier:refactor-labels-annotations
Jun 19, 2023
Merged

chore: refactor labels/annotations CLI flags#5683
ArthurSens merged 1 commit into
prometheus-operator:mainfrom
simonpasquier:refactor-labels-annotations

Conversation

@simonpasquier

Copy link
Copy Markdown
Contributor

Description

Follow-up of #5536

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


@simonpasquier
simonpasquier requested a review from a team as a code owner June 15, 2023 12:56
@simonpasquier
simonpasquier force-pushed the refactor-labels-annotations branch from 65695e6 to 57d066a Compare June 15, 2023 15:39
@simonpasquier
simonpasquier force-pushed the refactor-labels-annotations branch from 57d066a to a66d974 Compare June 16, 2023 08:10

@JoaoBraveCoding JoaoBraveCoding left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsome 🔥 lgtm

@ArthurSens
ArthurSens merged commit ad05b6c into prometheus-operator:main Jun 19, 2023
@simonpasquier
simonpasquier deleted the refactor-labels-annotations branch June 20, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants