-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more metrics #53
Conversation
Signed-off-by: Alexander Sharov <[email protected]>
Signed-off-by: Alexander Sharov <[email protected]>
6c13d13
to
5bbee68
Compare
Old output example:
New output example:
|
@SuperQ can you check it, please? |
Signed-off-by: Alexander Sharov <[email protected]>
@SuperQ up ;-) |
What's the difference between I'm thinking max is some kind of historical metric. I don't think we really need that as users can use |
Signed-off-by: Alexander Sharov <[email protected]>
agree |
@SuperQ can you check it one more time pls? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor nits.
Signed-off-by: Alexander Sharov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* [CHANGE] Use upstream ecs-agent types for deserializing API responses #75 * [CHANGE] Update exporter boilerplate #77 * [ENHANCEMENT] Add additional metrics #53 Signed-off-by: SuperQ <[email protected]>
* [CHANGE] Use upstream ecs-agent types for deserializing API responses #75 * [CHANGE] Update exporter boilerplate #77 * [ENHANCEMENT] Add additional metrics #53 Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Alexander Sharov [email protected]