Fix CPU usage metrics #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/fix_jiffies
branch
2 times, most recently
from
f86b04a to
2fe3f9a
Compare
The CPU usage metrics from ECS are pass-through of Docker stats API. * Switch the API json struct to use upstream Docker types. * The API specifies the units are in nanoseconds, not jiffies. Fixes: #34 Signed-off-by: SuperQ <[email protected]>
SuperQ
force-pushed
the
superq/fix_jiffies
branch
from
2fe3f9a to
6b84904
Compare
sysadmind
approved these changes
Jul 29, 2022
|
Any chance you can get this merged/built? Thanks. |
roidelapluie
approved these changes
Aug 2, 2022
SuperQ
added a commit
that referenced
this pull request
Aug 2, 2022
* [BUGFIX] Fix CPU usage metrics #37 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Aug 2, 2022
* [BUGFIX] Fix CPU usage metrics #37 Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Aug 2, 2022
* [BUGFIX] Fix CPU usage metrics #37 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CPU usage metrics from ECS are pass-through of Docker stats API.
Fixes: #34
Signed-off-by: SuperQ [email protected]