Api: Verify that at every matcher in api/v1/series is not empty#8288
Api: Verify that at every matcher in api/v1/series is not empty#8288bwplotka merged 1 commit intoprometheus:masterfrom
Conversation
Fixed prometheus#8286 Signed-off-by: Julien Pivotto <[email protected]>
|
It might be better to do this down in TSDB, so that we don't have to duplicate it every time we add matchers to an API endpoint. |
|
We can have it in TSDB, but I think we should keep it in PromQL too, to avoid asking everything to remote_read. WDYT? |
|
Or once in TSDB and one in remote read client. |
|
Failing fast for PromQL like we currently do makes sense I think, but let's not end up duplicating this N times in the API code. |
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM.
Well we could wrap it in parseMatchers function and that's it. Not sure if baking this in TSDB makes sense.
|
Thanks! |
|
The above discussion was not finished, this should not have been merged yet. The standing procedure is also that -team members merge their own PRs. |
|
Sorry, I did not see the discussion being still pending. It was quite trivial change to me and it looked like the discussion was about the future step. Sorry for premature merge! |
…etheus#8288) Fixed prometheus#8286 Signed-off-by: Julien Pivotto <[email protected]> Signed-off-by: Dominic Yin <[email protected]>
3 participants
Fixed #8286
Signed-off-by: Julien Pivotto [email protected]