Increment dirty counter only if setDirty(true) is called.#821
Merged
Conversation
Currently, we increment the counter even if setDirty(false) is called, which sets the storage clean.
Member
|
👍 |
beorn7
added a commit
that referenced
this pull request
Jun 22, 2015
Increment dirty counter only if setDirty(true) is called.
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this pull request
Oct 12, 2017
Add k8s ingress discovery
bwplotka
added a commit
that referenced
this pull request
Jan 31, 2025
Testing prometheus/test-infra#821 Signed-off-by: Bartlomiej Plotka <[email protected]>
zenador
pushed a commit
to zenador/prometheus
that referenced
this pull request
Mar 19, 2025
…che-main Revert "Merge pull request prometheus#15455 from bboreham/compact-cache-symbols"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we increment the counter even if setDirty(false) is called,
which sets the storage clean.
@juliusv