config: ensure correct labelname in JSON target group. #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Does that play well with Godeps? It looks like you changed the dependencies in the Godops workspace but not |
|
The author of Godeps described this as the way to do it. If you are waiting for a patch in a dependency, you know will be merged, just apply the patch to the dep folder and it will be overwritten with the next vendor upgrade. Makes way more sense to me then merging tests that fail until the next vendoring upgrade or leaving a bug unfixed until the next vendoring upgrade. We/I did this for the last few patches to |
|
I see... One day, I'll know to handle Godeps correctly... :) 👍 |
fabxc
added a commit
that referenced
this pull request
Jun 8, 2015
config: ensure correct labelname in JSON target group.
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this pull request
Oct 12, 2017
…index Marathon SD: Change port 'ordinal' to 'index'
julienduchesne
pushed a commit
to julienduchesne/prometheus
that referenced
this pull request
Dec 13, 2024
…-15426 [weekly-r319] MemPostings: keep a map of label values slices (prometheus#15426)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.