Break DB.Compact and DB.CompactHead and DB.CompactBlocks#6820
Merged
bwplotka merged 1 commit intoprometheus:masterfrom Feb 17, 2020
Merged
Break DB.Compact and DB.CompactHead and DB.CompactBlocks#6820bwplotka merged 1 commit intoprometheus:masterfrom
bwplotka merged 1 commit intoprometheus:masterfrom
Conversation
3 tasks
codesome
force-pushed
the
break-compact
branch
from
432a8dd to
2610571
Compare
codesome
changed the title
Contributor
|
These changes look great! Thank you! |
codesome
force-pushed
the
break-compact
branch
from
2610571 to
099cc6a
Compare
codesome
changed the title
…actHead. Signed-off-by: Ganesh Vernekar <[email protected]>
codesome
force-pushed
the
break-compact
branch
from
099cc6a to
6f1d2ec
Compare
pracucci
approved these changes
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just modularises the components in the
DB.Compact()while having no changes in the logic. This will help external projects like Cortex get access to individual methods (mainlyCompactHead)./cc @thorfour @pracucci