made stripe size configurable#6644
Merged
codesome merged 1 commit intoprometheus:masterfrom Jan 30, 2020
Merged
Conversation
thorfour
force-pushed
the
tsdb/stripe-size-option
branch
from
94e802e to
de3d2a4
Compare
codesome
reviewed
Jan 17, 2020
Member
codesome
left a comment
codesome
left a comment
There was a problem hiding this comment.
This change looks fine as long as it is not exposed via a flag, which is the case. I would prefer some explanation about the stripeSize in the comments for NewHead including what is the effect of increasing or decreasing it.
Signed-off-by: Thor <[email protected]>
thorfour
force-pushed
the
tsdb/stripe-size-option
branch
from
de3d2a4 to
29a3cc6
Compare
codesome
approved these changes
Jan 21, 2020
Member
codesome
left a comment
codesome
left a comment
There was a problem hiding this comment.
LGTM. I will wait for another maintainer to give +1 on this.
Contributor
Author
|
@krasi-georgiev any chance you could look at these changes? |
Contributor
|
LGTM |
boyskila
pushed a commit
to boyskila/prometheus
that referenced
this pull request
Mar 3, 2020
Signed-off-by: Thor <[email protected]>
boyskila
pushed a commit
to boyskila/prometheus
that referenced
this pull request
Mar 3, 2020
Signed-off-by: Thor <[email protected]> Signed-off-by: blalov <[email protected]>
4 tasks
ntk148v
added a commit
to ntk148v/prometheus
that referenced
this pull request
Apr 2, 2026
The PR prometheus#6644 is only internal configurability. This PR makes it truly configurable. Related-Issue: prometheus#17100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes exposes the
stripeSizeconst as a configurable option in tsdb. Not passing in the option will result in the tsdb using the default stripe size that is uses today.This is an important change for Cortex's new experimental TSDB feature as it allows us to reduce the memory footprint of TSDB's as they are scaled to many nodes. More info about this memory usage can be found here
@codesome @krasi-georgiev