Small size docker image refactoring#649
Small size docker image refactoring#649discordianfish merged 1 commit intoprometheus:masterfrom sdurrheimer:master
Conversation
Signed-off-by: Steve Durrheimer <[email protected]>
There was a problem hiding this comment.
I don't think /etc/prometheus should be a volume: People can bind-mount that anyway and if they don't want to use a volume for the config (which I would actually suggest to do) they have no way to prevent this from being a volume.
There was a problem hiding this comment.
I agree, I had some hesitation about that. I will make the modification soon, and squash it in the first commit if you want to.
|
If we were starting from a clean slate, I would fully agree with this PR. Since don't, I'm not sure we should move the console stuff and prometheus config. |
|
I moved consoles and consoles_libraries folders because of Then I moved /prometheus.conf in But I agree, this change breaks people images even if they only add |
|
Well we could still move things back after the rm -rf /go. But I tend towards just breaking downsteam. Providing Docker images and have people 'customize' them is a really new things and given that Docker doesn't provide any kind of contract, people simply can't expect the parent image to be stable. |
|
@discordianfish I think this depends in part on the culture, expectations, and "best practices" in Docker-land, so I'll trust your judgement here. |
Small size docker image refactoring
|
Well then :). Thanks a lot @sdurrheimer! |
Updated doc for prometheus/prometheus#649 docker image refactoring PR
|
+1 !! |
wal: Inject LiveReader metrics rather than registry
4 participants
Hi
As asked in #636, here the PR with my small size docker image refactoring.
This is a breaking change and will affect people having extended the
prom/prometheusimage for the following reasons :debian:jessie) toalpine:edge.I used the
edgetag of alpine base image because of golang version. Inalpine:3.1, golang version is1.3.3. In alpine:edge, it's1.4.2. Later on, we will be able to change toalpine:3.2when it released./go/src/github.com/prometheus/prometheus/console_librariesand/go/src/github.com/prometheus/prometheus/consolesfolders moved to /etc/prometheus/prometheus.conffile moved to/etc/prometheustoo.In this case, there is maybe some way of limiting the impact by pushing the current image as a new tag on docker hub. Therefore, people will be able to make the transition easily.
A PR will follow for the https://github.com/prometheus/docs repository.
Moreover, I will give a try on reducing docker image size of available exporters.
@discordianfish @juliusv