fixes space issue in duration range promql#6295
Merged
juliusv merged 6 commits intoprometheus:masterfrom Nov 11, 2019
Merged
Conversation
Signed-off-by: Harkishen-Singh <[email protected]>
Signed-off-by: Harkishen-Singh <[email protected]>
Member
|
@Harkishen-Singh Thanks! Rather than removing spaces from the duration token in the parser, it would be better to fix the lexer to just skip spaces (like it does in other places, e.g. https://github.com/prometheus/prometheus/blob/master/promql/lex.go#L578-L579) and just emit the actual duration string as the token. |
Contributor
Author
|
@juliusv sure. Thanks for the suggestion. |
Contributor
Author
|
@juliusv I have updated the lexer to skip over the spaces. Please have a look. |
Contributor
|
This should have unittests. |
Signed-off-by: Harkishen-Singh <[email protected]>
Contributor
Author
|
@brian-brazil @juliusv added unit tests. please have a look. |
Signed-off-by: Harkishen-Singh <[email protected]>
Contributor
|
👍 |
Member
|
👍 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harkishen-Singh [email protected]
fixes #6065