Add exemplar support to the openmetrics parser#6292
Merged
brian-brazil merged 9 commits intoprometheus:masterfrom Nov 19, 2019
Merged
Add exemplar support to the openmetrics parser#6292brian-brazil merged 9 commits intoprometheus:masterfrom
brian-brazil merged 9 commits intoprometheus:masterfrom
Conversation
shreyassrivatsan
force-pushed
the
ss/exemplar_support
branch
2 times, most recently
from
f12baf8 to
c98c70c
Compare
shreyassrivatsan
force-pushed
the
ss/exemplar_support
branch
from
44249f9 to
cba0feb
Compare
brian-brazil
reviewed
Nov 9, 2019
Contributor
brian-brazil
left a comment
brian-brazil
left a comment
There was a problem hiding this comment.
More negative unittests would be useful.
shreyassrivatsan
force-pushed
the
ss/exemplar_support
branch
from
cb52716 to
ebdea17
Compare
Contributor
|
Hmm, can you rebase to try and get rid of that test failure? |
Signed-off-by: Shreyas Srivatsan <[email protected]>
Signed-off-by: Shreyas Srivatsan <[email protected]>
Signed-off-by: Shreyas Srivatsan <[email protected]>
Signed-off-by: Shreyas Srivatsan <[email protected]>
Signed-off-by: Shreyas Srivatsan <[email protected]>
Signed-off-by: Shreyas Srivatsan <[email protected]>
Signed-off-by: Shreyas Srivatsan <[email protected]>
Signed-off-by: Shreyas Srivatsan <[email protected]>
Signed-off-by: Shreyas Srivatsan <[email protected]>
shreyassrivatsan
force-pushed
the
ss/exemplar_support
branch
from
ebdea17 to
4fd9d9e
Compare
Contributor
Author
Rebased and got rid of the test failures. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change adds support for exemplars in the openmetrics exposition format. It includes changes to the grammar and parsing of the expression along with tests.
It does change the behavior of the grammar. Now we expect an exemplar after the
#after a metric. The earlier grammar allow for random comments that were consumed by the parser.