Don't disable HTTP keep-alives for remote storage connections.#3173
Don't disable HTTP keep-alives for remote storage connections.#3173brian-brazil merged 1 commit intoprometheus:masterfrom
Conversation
|
@fabxc Should we just hardcode to enabled everywhere to make things easier for merging 2.0? https://github.com/prometheus/prometheus/blob/dev-2.0/util/httputil/client.go |
|
If we switched on keep-alive everywhere in 1.x, we might break people's setup with ulimits on fd count. To get this merged for the 1.8 release, can we keep it the way it currently is in this PR? |
|
I'm okay with merging as-is (or even disabling keep alive for remote read in 1.x and leaving it to 2.x), I would like @fabxc's opinion first though as any merge conflicts with 2.x will mostly affect him. |
|
I've discussed with @fabxc and we'll do things per this PR. Can you make the tests pass? |
bboreham
force-pushed
the
remote-keepalive-2
branch
from
8eeb6c2 to
a6cc196
Compare
Removes configurability introduced in prometheus#3160 in favour of hard-coding, per advice from @brian-brazil.
|
Thanks! |
… to 2.0 (see prometheus#3173) Removes configurability introduced in prometheus#3160 in favour of hard-coding, per advice from @brian-brazil.
…ctions.' to 2.0 (see prometheus#3173)" This reverts commit 0997191.
3 participants
Removes configurability introduced in #3160 in favour of hard-coding, per advice from @brian-brazil.
The slightly unwieldy
NewClientFromConfigAndOptions()is introduced to avoid changing the 13+ other calls toNewClientFromConfig()in this repo and presumably more downstream.