Re-enable http keepalive on remote storage#3171
Closed
bboreham wants to merge 2 commits intoprometheus:release-1.7from
Closed
Re-enable http keepalive on remote storage#3171bboreham wants to merge 2 commits intoprometheus:release-1.7from
bboreham wants to merge 2 commits intoprometheus:release-1.7from
Conversation
| // TLSConfig to use to connect to the targets. | ||
| TLSConfig TLSConfig `yaml:"tls_config,omitempty"` | ||
| // If set, override whether to use HTTP KeepAlive - scraping defaults OFF, remote read/write defaults ON | ||
| KeepAlive *bool `yaml:"keep_alive,omitempty"` |
Contributor
There was a problem hiding this comment.
I don't think this should be configurable.
Contributor
There was a problem hiding this comment.
That issue isn't about remote storage
Member
Author
There was a problem hiding this comment.
That line makes it configurable for scraping too.
Are you saying it should be non-configurable solely for remote storage? (which would be a change here)
Contributor
There was a problem hiding this comment.
I think it should be non-configurable generally.
Member
Author
There was a problem hiding this comment.
OK, so your comment does belong on #2498.
Also you might want to revert this change off master.
Member
Author
|
Any further thoughts on this? Obviously not still a candidate for 1.7.2. |
Member
Author
|
#3173 replaces this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #3160 as candidate for the 1.7.2 release
Allow HTTP keep-alive setting to be overridden in config, and default it ON for remote storage read/write