tsdb/record: eliminate prev pointer escapes in V2 histogram WAL decoder by miguelbernadi · Pull Request #18813 · prometheus/prometheus

miguelbernadi · 2026-05-28T19:44:12Z

Summary

The V2 histogram sample decoders (histogramSamplesV2, floatHistogramSamplesV2) tracked the previous sample's Ref and ST fields via a *RefHistogramSample pointer. Taking the address of a loop-local variable (prev = &rh) forced the compiler to heap-allocate rh on every iteration; the first iteration also allocated a separate sentinel struct. The pointed-to fields were only ever read as two int64 scalars, so the pointer served no purpose.

This PR replaces prev with two scalar variables (prevRef, prevST) and a boolean sentinel, keeping rh on the stack.

This affects every caller of dec.HistogramSamples that produces V2 records (EnableSTStorage=true): WAL replay, the WAL watcher (remote write tail), and checkpoint creation.

A first commit adds two benchmark shapes — an all-histogram WAL and a mixed 50/50 WAL — to BenchmarkLoadWLs, plus a new BenchmarkDecodeHistogramSamples in tsdb/record that isolates the V1/V2 decoder paths. These were used to validate the fix and will serve future work on the histogram decode hot path (finding 3: pooling *histogram.Histogram objects).

Benchmark results

go test -count=6 -benchmem, compared with benchstat:

BenchmarkDecodeHistogramSamples (tsdb/record) — decoder in isolation:

                      │    before    │              after               │
                      │   allocs/op  │  allocs/op    vs base            │
buckets=0/v2          │  2.001k ± 0% │  1.000k ± 0%  -50.02% (p=0.002) │
buckets=4/v2          │  4.001k ± 0% │  3.000k ± 0%  -25.02% (p=0.002) │
buckets=16/v2         │  4.001k ± 0% │  3.000k ± 0%  -25.02% (p=0.002) │

                      │    before    │              after               │
                      │    B/op      │    B/op       vs base            │
buckets=0/v2          │ 187.5Ki ± 0% │ 156.2Ki ± 0%  -16.68% (p=0.002) │
buckets=4/v2          │ 250.0Ki ± 0% │ 218.8Ki ± 0%  -12.51% (p=0.002) │
buckets=16/v2         │ 437.5Ki ± 0% │ 406.2Ki ± 0%   -7.15% (p=0.002) │

V1 paths are unchanged (p >> 0.05 throughout).

BenchmarkLoadWLs (tsdb) — end-to-end WAL replay, stStorage=true only:

                          │    before     │              after               │
                          │   allocs/op   │  allocs/op    vs base            │
histogramSeriesPct=1.000  │  19.70M ± 0%  │  14.90M ± 0%  -24.39% (p=0.002) │
histogramSeriesPct=0.500  │  10.47M ± 0%  │   8.06M ± 0%  -23.00% (p=0.002) │

                          │    before     │              after               │
                          │    B/op       │    B/op       vs base            │
histogramSeriesPct=1.000  │  1.539Gi ± 0% │  1.394Gi ± 0%  -9.42% (p=0.002) │
histogramSeriesPct=0.500  │  1051.3Mi ± 0%│  975.1Mi ± 0%  -7.25% (p=0.002) │

                          │    before     │              after               │
                          │    sec/op     │    sec/op     vs base            │
histogramSeriesPct=1.000  │  824.9m ± 0%  │  762.6m ± 1%   -7.55% (p=0.002) │
histogramSeriesPct=0.500  │  488.6m ± 1%  │  451.4m ± 1%   -7.61% (p=0.002) │

Float-only shapes are unchanged (p >> 0.05 throughout).

[PERF] tsdb/record: Eliminate unnecessary heap allocations in the V2 histogram WAL decoder, reducing allocations by up to 50% and memory by up to 10% for deployments using native histograms with created-timestamp storage enabled (`--enable-feature=created-timestamp-zero-ingestion`).

Add two benchmark components to measure the native histogram decode hot path, which is shared by WAL replay, WAL watcher (remote write), and checkpoint creation. tsdb/record: BenchmarkDecodeHistogramSamples isolates the V1 and V2 histogram decoder paths across bucket counts (0, 4, 16), giving a precise per-sample allocation signal for decoder changes. tsdb: BenchmarkLoadWLs gains two new shapes: - all-histogram (histogramSeriesPct=1.0, bucketsPerHistogram=8): mirrors the existing "In between" float shape for direct comparison. - mixed (histogramSeriesPct=0.5, bucketsPerHistogram=8): models a deployment partway through migrating to native histograms. Both shapes are parameterised over stStorage (V1 vs V2 encoding) via the existing enableSTStorage loop, so benchstat can show the V1/V2 delta without additional test infrastructure. The subtest names include histogramSeriesPct and bucketsPerHistogram only when non-zero, leaving existing float-only subtest names unchanged. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Signed-off-by: Miguel Bernabeu Diaz <[email protected]>

histogramSamplesV2 and floatHistogramSamplesV2 tracked the previous sample's Ref and ST via a *RefHistogramSample pointer (prev). Taking the address of a loop-local variable (prev = &rh) forced the compiler to heap-allocate rh on every iteration; the first iteration also allocated a separate sentinel struct. The pointed-to fields were only ever read as two int64 scalars, so the pointer added zero semantic value. Replace prev with two scalar variables (prevRef, prevST) and a boolean sentinel. rh no longer has its address taken and stays on the stack. This affects every caller of dec.HistogramSamples that produces V2 records (EnableSTStorage=true): WAL replay, the WAL watcher (remote write tail), and checkpoint creation. Benchmarks (go test -count=6 -benchmem, benchstat): BenchmarkDecodeHistogramSamples (tsdb/record) │ before │ after │ │ allocs/op │ allocs/op vs base │ buckets=0/v2 │ 2.001k ± 0%│ 1.000k ± 0% -50.02% (p=0.002)│ buckets=4/v2 │ 4.001k ± 0%│ 3.000k ± 0% -25.02% (p=0.002)│ buckets=16/v2 │ 4.001k ± 0%│ 3.000k ± 0% -25.02% (p=0.002)│ │ before │ after │ │ B/op │ B/op vs base │ buckets=0/v2 │ 187.5Ki ± 0%│ 156.2Ki ± 0% -16.68% (p=0.002)│ buckets=4/v2 │ 250.0Ki ± 0%│ 218.8Ki ± 0% -12.51% (p=0.002)│ buckets=16/v2 │ 437.5Ki ± 0%│ 406.2Ki ± 0% -7.15% (p=0.002)│ BenchmarkLoadWLs end-to-end WAL replay (tsdb), stStorage=true only │ before │ after │ │ allocs/op │ allocs/op vs base │ histogramSeriesPct=1.000 │ 19.70M ± 0% │ 14.90M ± 0% -24.39% (p=0.002)│ histogramSeriesPct=0.500 │ 10.47M ± 0% │ 8.06M ± 0% -23.00% (p=0.002)│ │ before │ after │ │ B/op │ B/op vs base │ histogramSeriesPct=1.000 │ 1.539Gi ± 0%│ 1.394Gi ± 0% -9.42% (p=0.002)│ histogramSeriesPct=0.500 │ 1051.3Mi ± 0%│ 975.1Mi ± 0% -7.25% (p=0.002)│ │ before │ after │ │ sec/op │ sec/op vs base │ histogramSeriesPct=1.000 │ 824.9m ± 0% │ 762.6m ± 1% -7.55% (p=0.002)│ histogramSeriesPct=0.500 │ 488.6m ± 1% │ 451.4m ± 1% -7.61% (p=0.002)│ V1 paths and float-only shapes are unchanged (p >> 0.05 throughout). Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Signed-off-by: Miguel Bernabeu Diaz <[email protected]>

miguelbernadi · 2026-05-28T20:01:03Z

~~Potentially related to #16942 (General garbage optimizations if possible.).~~

Confirmed unrelated.

bwplotka

Looks sensible, thanks!

How you found it? Did you try using ST flow?

Also, it's not related to the issue (replay) as it's a new feature, opt-in.

miguelbernadi · 2026-06-01T09:07:42Z

I was reviewing the PR from my colleague (#18806) and checking allocations with Claude when it spotted a couple potentially unnecessary high-allocation spots. As those were unrelated to my colleague's proposal, I went looking for to verify them in main and see if it was worth patching them.

miguelbernadi · 2026-06-01T09:08:58Z

Did you try using ST flow?

I have not. It was pure static code analysis to find the allocations and targeted benchmarking to verify their impact.

Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Miguel Bernabeu Diaz <[email protected]>

…➔ v3.13.0) (#1360) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/prometheus](https://github.com/prometheus/prometheus) | minor | `v3.12.0` → `v3.13.0` | --- ### Release Notes <details> <summary>prometheus/prometheus (quay.io/prometheus/prometheus)</summary> ### [`v3.13.0`](https://github.com/prometheus/prometheus/releases/tag/v3.13.0): 3.13.0 / 2026-07-01 [Compare Source](prometheus/prometheus@v3.12.0...v3.13.0) This is a Long Term Support [LTS](https://prometheus.io/docs/introduction/release-cycle/) release. - \[SECURITY] UI: Bump `sanitize-html` to fix a cross-site scripting vulnerability (CVE-2026-44990). [#18697](prometheus/prometheus#18697) - \[CHANGE] UI: Third-party npm dependency licenses are now embedded in the Prometheus binary and served at `/assets/third-party-licenses.txt`, replacing the `npm_licenses.tar.bz2` archive previously shipped in release tarballs and container images. [#18997](prometheus/prometheus#18997) - \[CHANGE] API: Use SHA-256 instead of SHA-1 to generate rule group pagination tokens. [#18927](prometheus/prometheus#18927) - \[CHANGE] HTTP clients: Credentials (Authorization header, basic auth, bearer token, OAuth2, configured headers) are no longer forwarded when following a redirect to a different host; affects scraping, remote read/write, alerting, and service discovery. Via prometheus/common v0.69.0 (CVE-2025-4673 CVE-2023-45289). [#18949](prometheus/prometheus#18949) - \[CHANGE] promtool: Relative file paths in the file passed to `--http.config.file` are now resolved relative to that config file's directory instead of its parent directory. Via prometheus/common v0.69.0. [#18949](prometheus/prometheus#18949) - \[CHANGE] PromQL: Rename the `min()` and `max()` duration-expression functions (experimental feature flag `experimental-duration-expr`) to `min_of()` and `max_of()` to avoid confusion with the `min` and `max` aggregate operators. [#18687](prometheus/prometheus#18687) - \[FEATURE] API: Add experimental search endpoints to search metric names, label names, and label values. [#18573](prometheus/prometheus#18573) - \[FEATURE] Discovery/AWS: Add ability to filter RDS instances. [#18859](prometheus/prometheus#18859) - \[FEATURE] PromQL: Add `min_of(a, b)` and `max_of(a, b)` scalar experimental functions, returning the smaller or larger of two scalar values. [#18687](prometheus/prometheus#18687) - \[FEATURE] PromQL: Add support for smoothed/anchored rate with native histograms. [#18564](prometheus/prometheus#18564) - \[FEATURE] PromQL: Expose per-query `samplesRead` (and `samplesReadPerStep` with `stats=all` and the `promql-per-step-stats` feature flag) in the query stats response, and add the `prometheus_engine_query_samples_read_total` engine counter. `samplesRead` reflects storage I/O distinct from `totalQueryableSamples`, which counts samples loaded into the evaluator (and so over-counts when a sample is reused across multiple range-vector windows). [#18081](prometheus/prometheus#18081) - \[FEATURE] Scrape: Add `__convert_classic_histograms_to_nhcb__` internal label to allow per-target override of `convert_classic_histograms_to_nhcb` scrape configuration via relabeling. [#18840](prometheus/prometheus#18840) - \[FEATURE] TSDB: Add `storage.tsdb.chunk_encoding.floats` configuration field to select float chunk encoding (`xor` or `xor2`) at runtime, independently of the `--enable-feature=xor2-encoding` flag. [#18769](prometheus/prometheus#18769) - \[FEATURE] remote\_write: Add Certificate support for ingesting data into an Azure Monitor Workspace. [#18217](prometheus/prometheus#18217) - \[FEATURE] Scrape: Add `__always_scrape_classic_histograms__` and `__scrape_native_histograms__` internal labels to allow per-target override of the `always_scrape_classic_histograms` and `scrape_native_histograms` scrape configuration via relabeling. [#18929](prometheus/prometheus#18929) - \[ENHANCEMENT] Release: Container images are now also published to the GitHub Container Registry (ghcr.io). [#18791](prometheus/prometheus#18791) - \[ENHANCEMENT] PromQL: Prettify `fill_left(x) fill_right(x)` as `fill(x)` when both fill values are equal. [#18851](prometheus/prometheus#18851) - \[ENHANCEMENT] UI: Improve autocompletion after closing a function bracket. [#18894](prometheus/prometheus#18894) - \[PERF] Labels: Add case-insensitive prefix matching to speed up evaluation of long case-insensitive regular expressions (up to \~2x faster). [#18540](prometheus/prometheus#18540) - \[PERF] TSDB: Reduce per-sample overhead in chunk population, speeding up affected queries by \~12-15% in benchmarks. [#18699](prometheus/prometheus#18699) - \[PERF] TSDB: Eliminate unnecessary heap allocations in the V2 histogram WAL decoder, reducing allocations by up to 50% and memory by up to 10% for deployments using native histograms with created-timestamp storage enabled (`--enable-feature=created-timestamp-zero-ingestion`). [#18813](prometheus/prometheus#18813) - \[BUGFIX] Discovery/AWS: Fix failure when processing an AWS RDS cluster without instances. [#18845](prometheus/prometheus#18845) - \[BUGFIX] Fix race condition in initTime that could cause ErrOutOfBounds. [#18629](prometheus/prometheus#18629) - \[BUGFIX] PromQL: A range query whose `end` was not aligned to `step` caused subqueries inside it to evaluate past the parent's last actual step, inflating `peakSamples` in the query stats and against the `query.max-samples` limit, and wasting storage I/O reading samples that were never used in the result. [#18081](prometheus/prometheus#18081) - \[BUGFIX] PromQL: A range query containing an at-modifier-unsafe function over a range-vector with an `@` modifier (e.g. `predict_linear(metric[60s] @ T, X)`) silently under-counted `totalQueryableSamples` for steps after step 0. [#18081](prometheus/prometheus#18081) - \[BUGFIX] PromQL: Fix `fill_left`/`fill_right` producing missing samples in range queries when using `group_left`/`group_right`. [#18850](prometheus/prometheus#18850) - \[BUGFIX] PromQL: Fix for resets() and changes() in anchored range extenders with histograms. [#18906](prometheus/prometheus#18906) - \[BUGFIX] PromQL: Fix panic on `1[5m] smoothed` and similar expressions when extended range selectors are enabled. [#18764](prometheus/prometheus#18764) - \[BUGFIX] PromQL: Fix panic when a `smoothed` instant vector selector produces no samples for a series. [#18943](prometheus/prometheus#18943) - \[BUGFIX] PromQL: Fix panic when using a parenthesised plain number as an offset (e.g. `foo offset -(5)`). [#18768](prometheus/prometheus#18768) - \[BUGFIX] promtool: Fix panic when parsing exposition text containing empty braces `{}`. Via prometheus/common v0.69.0. [#18949](prometheus/prometheus#18949) - \[BUGFIX] Promtool: Fix `check healthy` and `check ready` when `--url` ends with a trailing slash. [#18854](prometheus/prometheus#18854) - \[BUGFIX] Rules: Close PromQL query after each rule evaluation to ensure resources are released. [#18733](prometheus/prometheus#18733) - \[BUGFIX] Scaleway SD: Resolve VPC/IPAM-only instances that have no legacy `private_ip` or `public_ip` field, but do have private NICs attached. [#18772](prometheus/prometheus#18772) - \[BUGFIX] TSDB: Do not leak head series when an integer histogram append is rejected (e.g. out-of-order). [#18838](prometheus/prometheus#18838) - \[BUGFIX] UI: Escape label values offered by PromQL autocomplete. [#18658](prometheus/prometheus#18658) - \[BUGFIX] TSDB: Fix chunk snapshot encoding for EncXOR2 chunks, preventing corruption on TSDB restart when EncXOR2-encoded series were present. [#18739](prometheus/prometheus#18739) - \[BUGFIX] TSDB: Store a millisecond timestamp (not a WAL segment number) in walExpiries when a series is evicted via CompactStaleHead/CompactSelectedSeries, so the series's label record is correctly retained in the next WAL checkpoint and replays cleanly. [#18847](prometheus/prometheus#18847) - \[BUGFIX] TSDB: Prevent loss of samples at the chunk-range boundary when CompactSelectedSeries (and CompactStaleHead) evict the series — the per-slice compaction loop now runs one more iteration so the boundary timestamp is captured in a block before the in-memory copy is removed. [#18849](prometheus/prometheus#18849) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/1360

##### [\`v3.13.0\`](https://github.com/prometheus/prometheus/releases/tag/v3.13.0) This is a Long Term Support [LTS](https://prometheus.io/docs/introduction/release-cycle/) release. - \[SECURITY] UI: Bump `sanitize-html` to fix a cross-site scripting vulnerability (CVE-2026-44990). [#18697](prometheus/prometheus#18697) - \[CHANGE] UI: Third-party npm dependency licenses are now embedded in the Prometheus binary and served at `/assets/third-party-licenses.txt`, replacing the `npm_licenses.tar.bz2` archive previously shipped in release tarballs and container images. [#18997](prometheus/prometheus#18997) - \[CHANGE] API: Use SHA-256 instead of SHA-1 to generate rule group pagination tokens. [#18927](prometheus/prometheus#18927) - \[CHANGE] HTTP clients: Credentials (Authorization header, basic auth, bearer token, OAuth2, configured headers) are no longer forwarded when following a redirect to a different host; affects scraping, remote read/write, alerting, and service discovery. Via prometheus/common v0.69.0 (CVE-2025-4673 CVE-2023-45289). [#18949](prometheus/prometheus#18949) - \[CHANGE] promtool: Relative file paths in the file passed to `--http.config.file` are now resolved relative to that config file's directory instead of its parent directory. Via prometheus/common v0.69.0. [#18949](prometheus/prometheus#18949) - \[CHANGE] PromQL: Rename the `min()` and `max()` duration-expression functions (experimental feature flag `experimental-duration-expr`) to `min_of()` and `max_of()` to avoid confusion with the `min` and `max` aggregate operators. [#18687](prometheus/prometheus#18687) - \[FEATURE] API: Add experimental search endpoints to search metric names, label names, and label values. [#18573](prometheus/prometheus#18573) - \[FEATURE] Discovery/AWS: Add ability to filter RDS instances. [#18859](prometheus/prometheus#18859) - \[FEATURE] PromQL: Add `min_of(a, b)` and `max_of(a, b)` scalar experimental functions, returning the smaller or larger of two scalar values. [#18687](prometheus/prometheus#18687) - \[FEATURE] PromQL: Add support for smoothed/anchored rate with native histograms. [#18564](prometheus/prometheus#18564) - \[FEATURE] PromQL: Expose per-query `samplesRead` (and `samplesReadPerStep` with `stats=all` and the `promql-per-step-stats` feature flag) in the query stats response, and add the `prometheus_engine_query_samples_read_total` engine counter. `samplesRead` reflects storage I/O distinct from `totalQueryableSamples`, which counts samples loaded into the evaluator (and so over-counts when a sample is reused across multiple range-vector windows). [#18081](prometheus/prometheus#18081) - \[FEATURE] Scrape: Add `__convert_classic_histograms_to_nhcb__` internal label to allow per-target override of `convert_classic_histograms_to_nhcb` scrape configuration via relabeling. [#18840](prometheus/prometheus#18840) - \[FEATURE] TSDB: Add `storage.tsdb.chunk_encoding.floats` configuration field to select float chunk encoding (`xor` or `xor2`) at runtime, independently of the `--enable-feature=xor2-encoding` flag. [#18769](prometheus/prometheus#18769) - \[FEATURE] remote\_write: Add Certificate support for ingesting data into an Azure Monitor Workspace. [#18217](prometheus/prometheus#18217) - \[FEATURE] Scrape: Add `__always_scrape_classic_histograms__` and `__scrape_native_histograms__` internal labels to allow per-target override of the `always_scrape_classic_histograms` and `scrape_native_histograms` scrape configuration via relabeling. [#18929](prometheus/prometheus#18929) - \[ENHANCEMENT] Release: Container images are now also published to the GitHub Container Registry (ghcr.io). [#18791](prometheus/prometheus#18791) - \[ENHANCEMENT] PromQL: Prettify `fill_left(x) fill_right(x)` as `fill(x)` when both fill values are equal. [#18851](prometheus/prometheus#18851) - \[ENHANCEMENT] UI: Improve autocompletion after closing a function bracket. [#18894](prometheus/prometheus#18894) - \[PERF] Labels: Add case-insensitive prefix matching to speed up evaluation of long case-insensitive regular expressions (up to \~2x faster). [#18540](prometheus/prometheus#18540) - \[PERF] TSDB: Reduce per-sample overhead in chunk population, speeding up affected queries by \~12-15% in benchmarks. [#18699](prometheus/prometheus#18699) - \[PERF] TSDB: Eliminate unnecessary heap allocations in the V2 histogram WAL decoder, reducing allocations by up to 50% and memory by up to 10% for deployments using native histograms with created-timestamp storage enabled (`--enable-feature=created-timestamp-zero-ingestion`). [#18813](prometheus/prometheus#18813) - \[BUGFIX] Discovery/AWS: Fix failure when processing an AWS RDS cluster without instances. [#18845](prometheus/prometheus#18845) - \[BUGFIX] Fix race condition in initTime that could cause ErrOutOfBounds. [#18629](prometheus/prometheus#18629) - \[BUGFIX] PromQL: A range query whose `end` was not aligned to `step` caused subqueries inside it to evaluate past the parent's last actual step, inflating `peakSamples` in the query stats and against the `query.max-samples` limit, and wasting storage I/O reading samples that were never used in the result. [#18081](prometheus/prometheus#18081) - \[BUGFIX] PromQL: A range query containing an at-modifier-unsafe function over a range-vector with an `@` modifier (e.g. `predict_linear(metric[60s] @ T, X)`) silently under-counted `totalQueryableSamples` for steps after step 0. [#18081](prometheus/prometheus#18081) - \[BUGFIX] PromQL: Fix `fill_left`/`fill_right` producing missing samples in range queries when using `group_left`/`group_right`. [#18850](prometheus/prometheus#18850) - \[BUGFIX] PromQL: Fix for resets() and changes() in anchored range extenders with histograms. [#18906](prometheus/prometheus#18906) - \[BUGFIX] PromQL: Fix panic on `1[5m] smoothed` and similar expressions when extended range selectors are enabled. [#18764](prometheus/prometheus#18764) - \[BUGFIX] PromQL: Fix panic when a `smoothed` instant vector selector produces no samples for a series. [#18943](prometheus/prometheus#18943) - \[BUGFIX] PromQL: Fix panic when using a parenthesised plain number as an offset (e.g. `foo offset -(5)`). [#18768](prometheus/prometheus#18768) - \[BUGFIX] promtool: Fix panic when parsing exposition text containing empty braces `{}`. Via prometheus/common v0.69.0. [#18949](prometheus/prometheus#18949) - \[BUGFIX] Promtool: Fix `check healthy` and `check ready` when `--url` ends with a trailing slash. [#18854](prometheus/prometheus#18854) - \[BUGFIX] Rules: Close PromQL query after each rule evaluation to ensure resources are released. [#18733](prometheus/prometheus#18733) - \[BUGFIX] Scaleway SD: Resolve VPC/IPAM-only instances that have no legacy `private_ip` or `public_ip` field, but do have private NICs attached. [#18772](prometheus/prometheus#18772) - \[BUGFIX] TSDB: Do not leak head series when an integer histogram append is rejected (e.g. out-of-order). [#18838](prometheus/prometheus#18838) - \[BUGFIX] UI: Escape label values offered by PromQL autocomplete. [#18658](prometheus/prometheus#18658) - \[BUGFIX] TSDB: Fix chunk snapshot encoding for EncXOR2 chunks, preventing corruption on TSDB restart when EncXOR2-encoded series were present. [#18739](prometheus/prometheus#18739) - \[BUGFIX] TSDB: Store a millisecond timestamp (not a WAL segment number) in walExpiries when a series is evicted via CompactStaleHead/CompactSelectedSeries, so the series's label record is correctly retained in the next WAL checkpoint and replays cleanly. [#18847](prometheus/prometheus#18847) - \[BUGFIX] TSDB: Prevent loss of samples at the chunk-range boundary when CompactSelectedSeries (and CompactStaleHead) evict the series — the per-slice compaction loop now runs one more iteration so the boundary timestamp is captured in a block before the in-memory copy is removed. [#18849](prometheus/prometheus#18849)

miguelbernadi and others added 2 commits May 28, 2026 21:40

miguelbernadi requested review from a team, bwplotka, codesome, jesusvazquez and krajorama as code owners May 28, 2026 19:44

bwplotka approved these changes May 28, 2026

View reviewed changes

Comment thread tsdb/record/record.go Outdated

Update tsdb/record/record.go

423c787

Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Miguel Bernabeu Diaz <[email protected]>

miguelbernadi force-pushed the improve-hostogram-allocations branch from aaea469 to 423c787 Compare June 1, 2026 09:13

bwplotka approved these changes Jun 1, 2026

View reviewed changes

bwplotka merged commit 178c53d into prometheus:main Jun 1, 2026
35 checks passed

github-actions Bot mentioned this pull request Jul 24, 2026

Update prom/prometheus Docker tag to v3.13.1 claytono/infra#2595

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tsdb/record: eliminate prev pointer escapes in V2 histogram WAL decoder#18813

tsdb/record: eliminate prev pointer escapes in V2 histogram WAL decoder#18813
bwplotka merged 3 commits into
prometheus:mainfrom
miguelbernadi:improve-hostogram-allocations

miguelbernadi commented May 28, 2026

Uh oh!

miguelbernadi commented May 28, 2026 •

edited

Loading

Uh oh!

bwplotka left a comment

Uh oh!

Uh oh!

miguelbernadi commented Jun 1, 2026

Uh oh!

miguelbernadi commented Jun 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

miguelbernadi commented May 28, 2026

Summary

Benchmark results

Uh oh!

miguelbernadi commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bwplotka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miguelbernadi commented Jun 1, 2026

Uh oh!

miguelbernadi commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

miguelbernadi commented May 28, 2026 •

edited

Loading

miguelbernadi commented Jun 1, 2026 •

edited

Loading