remote/azuread: use Secret type for OAuth client_secret#18587
Merged
roidelapluie merged 1 commit intoApr 27, 2026
Merged
Conversation
The ClientSecret field in OAuthConfig was typed as plain string, causing it to be exposed in plaintext via the /-/config HTTP endpoint. Change it to config_util.Secret so Prometheus redacts it as <secret>. Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
requested review from
a team,
alexgreenbank,
bwplotka,
cstyan and
tomwilkie
as code owners
April 27, 2026 10:20
krajorama
approved these changes
Apr 27, 2026
Merged
4 tasks
|
Fix included in release 5.0.0-0.nightly-2026-07-01-125918 |
|
Fix included in release 4.22.0-0.nightly-2026-07-03-024128 |
This was referenced Jul 7, 2026
openshift-merge-bot Bot
pushed a commit
to stolostron/thanos
that referenced
this pull request
Jul 8, 2026
Use a replace directive to point github.com/prometheus/prometheus to stolostron/prometheus@cve-2026-42151-v0.308.0 which contains the upstream fix (prometheus/prometheus#18587) cherry-picked onto v0.308.0. The fix changes ClientSecret in the Azure AD OAuth config from string to config.Secret so that it is properly redacted by the /-/config API endpoint. Ref: GHSA-wg65-39gg-5wfj Ref: ACM-36251 Signed-off-by: Coleen Iona Quadros <[email protected]> Signed-off-by: Coleen Iona Quadros <[email protected]>
coleenquadros
added a commit
to stolostron/multicluster-observability-operator
that referenced
this pull request
Jul 9, 2026
Bump github.com/prometheus/prometheus from v0.305.0 to v0.305.3 to fix CVE-2026-42151 (GHSA-wg65-39gg-5wfj): Prometheus Azure AD remote write OAuth client_secret was exposed via config API because the ClientSecret field in storage/remote/azuread OAuthConfig was typed as string instead of config_util.Secret, bypassing redaction. Upstream fix: prometheus/prometheus#18587, #18590 Jira: ACM-36210, ACM-36241, ACM-36249, ACM-36250 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Coleen Iona Quadros <[email protected]>
coleenquadros
added a commit
to stolostron/multicluster-observability-operator
that referenced
this pull request
Jul 9, 2026
Bump github.com/prometheus/prometheus from v0.305.0 to v0.305.3 to fix CVE-2026-42151 (GHSA-wg65-39gg-5wfj): Prometheus Azure AD remote write OAuth client_secret was exposed via config API because the ClientSecret field in storage/remote/azuread OAuthConfig was typed as string instead of config_util.Secret, bypassing redaction. Upstream fix: prometheus/prometheus#18587, #18590 Jira: ACM-36210, ACM-36241, ACM-36249, ACM-36250 Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClientSecret field in OAuthConfig was typed as plain string, causing it to be exposed in plaintext via the /-/config HTTP endpoint. Change it to config_util.Secret so Prometheus redacts it as .
Fixes GHSA-wg65-39gg-5wfj.
Which issue(s) does the PR fix:
Release notes for end users (ALL commits must be considered).
Reviewers should verify clarity and quality.