remote/azuread: use Secret type for OAuth client_secret#18586
Merged
roidelapluie merged 1 commit intoApr 27, 2026
Conversation
The ClientSecret field in OAuthConfig was typed as plain string, causing it to be exposed in plaintext via the /-/config HTTP endpoint. Change it to config_util.Secret so Prometheus redacts it as <secret>. Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
requested review from
a team,
alexgreenbank,
bwplotka,
cstyan and
tomwilkie
as code owners
April 27, 2026 10:19
Merged
2 tasks
vporoshok
added a commit
to deckhouse/prompp
that referenced
this pull request
May 16, 2026
…26-42151) (#337) Backport of upstream prometheus/prometheus#18586 (GHSA-wg65-39gg-5wfj). ClientSecret in OAuthConfig was typed as a plain string, so the value leaked verbatim through the /-/config HTTP endpoint. Switch the field to config.Secret so prometheus/common's MarshalYAML/MarshalJSON implementations redact it to <secret> on serialization; the value is explicitly converted back to string only at the azidentity boundary. Signed-off-by: Bastrykov Evgeniy <[email protected]> Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClientSecret field in OAuthConfig was typed as plain string, causing it to be exposed in plaintext via the /-/config HTTP endpoint. Change it to config_util.Secret so Prometheus redacts it as
<secret>.Fixes GHSA-wg65-39gg-5wfj.
Which issue(s) does the PR fix:
Release notes for end users (ALL commits must be considered).
Reviewers should verify clarity and quality.