Skip to content

remote: validate snappy decoded length before allocation in read enpoint#18585

Merged
roidelapluie merged 1 commit into
prometheus:release-3.5from
roidelapluie:roidelapluie/snappylength-lts
Apr 27, 2026
Merged

remote: validate snappy decoded length before allocation in read enpoint#18585
roidelapluie merged 1 commit into
prometheus:release-3.5from
roidelapluie:roidelapluie/snappylength-lts

Conversation

@roidelapluie

Copy link
Copy Markdown
Member

Fixes GHSA-8rm2-7qqf-34qm.

Which issue(s) does the PR fix:

Release notes for end users (ALL commits must be considered).

Reviewers should verify clarity and quality.

[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit

@krajorama krajorama left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp, based off #18584

@roidelapluie
roidelapluie merged commit 3ac0063 into prometheus:release-3.5 Apr 27, 2026
31 checks passed
sidharth-jain23 added a commit to hypertrace/service-framework that referenced this pull request May 15, 2026
CVE-2026-42154 (CVSS 7.5) is a DoS vulnerability in the Prometheus
server's /api/v1/read remote read endpoint (Go binary, fixed in
v3.5.3 and v3.11.3). OWASP dependency-check incorrectly matches
io.prometheus:simpleclient* Java jars against the same CPE
(cpe:2.3:a:prometheus:prometheus) due to the shared "prometheus" name.

The Java simpleclient library is a metrics instrumentation library
and does not contain the affected remote read endpoint. This is a
confirmed false positive per NVD (https://nvd.nist.gov/vuln/detail/CVE-2026-42154)
which lists only the prometheus/prometheus Go server as affected.

References:
- NVD: https://nvd.nist.gov/vuln/detail/CVE-2026-42154
- Fix PRs: prometheus/prometheus#18584, prometheus/prometheus#18585
- Advisory: GHSA-8rm2-7qqf-34qm

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Deepanshu0703 pushed a commit to hypertrace/service-framework that referenced this pull request May 15, 2026
* chore: upgrade Jetty from 11.0.26 to 12.1.9 (ee10)

Migrate from Jetty 11 to Jetty 12.1.9 using ee10 servlet compatibility layer:
- Update hypertrace-bom catalog version to 0.3.79 (includes Jetty 12.1.9)
- Update jakarta-servlet-api from 6.0.0 to 6.1.0
- Update servlet imports from o.e.j.servlet.* to o.e.j.ee10.servlet.*
- Update servlets imports from o.e.j.servlets.* to o.e.j.ee10.servlets.*
- Fix setVirtualHosts(String[]) to setVirtualHosts(List<String>)
- Remove setShowServlet(false) (method removed in 12.1.x, behavior is now default)
- Change ErrorHandler variable type to ErrorHandler from ee10 package
- Regenerate all gradle lock files

Co-Authored-By: Claude Opus 4.6 <[email protected]>

* fix: suppress false positive CVE-2026-42154 for prometheus simpleclient

CVE-2026-42154 (CVSS 7.5) is a DoS vulnerability in the Prometheus
server's /api/v1/read remote read endpoint (Go binary, fixed in
v3.5.3 and v3.11.3). OWASP dependency-check incorrectly matches
io.prometheus:simpleclient* Java jars against the same CPE
(cpe:2.3:a:prometheus:prometheus) due to the shared "prometheus" name.

The Java simpleclient library is a metrics instrumentation library
and does not contain the affected remote read endpoint. This is a
confirmed false positive per NVD (https://nvd.nist.gov/vuln/detail/CVE-2026-42154)
which lists only the prometheus/prometheus Go server as affected.

References:
- NVD: https://nvd.nist.gov/vuln/detail/CVE-2026-42154
- Fix PRs: prometheus/prometheus#18584, prometheus/prometheus#18585
- Advisory: GHSA-8rm2-7qqf-34qm

Co-Authored-By: Claude Opus 4.6 <[email protected]>

* Revert "fix: suppress false positive CVE-2026-42154 for prometheus simpleclient"

This reverts commit f95e9d0.

---------

Co-authored-by: Claude Opus 4.6 <[email protected]>
@openshift-merge-robot

Copy link
Copy Markdown

Fix included in release 4.21.0-0.nightly-2026-07-13-235512

@openshift-merge-robot

Copy link
Copy Markdown

Fix included in release 4.20.0-0.nightly-2026-07-15-212908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants