remote: validate snappy decoded length before allocation in read endpoint#18584
Merged
roidelapluie merged 1 commit intoApr 27, 2026
Merged
Conversation
…oint Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
requested review from
a team,
alexgreenbank,
bwplotka,
cstyan and
tomwilkie
as code owners
April 27, 2026 10:11
krajorama
approved these changes
Apr 27, 2026
krajorama
left a comment
Member
There was a problem hiding this comment.
LGTM. It's really unlikely anyone would hit the limit in a normal use case.
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
Apr 28, 2026
… v3.11.3) (#303) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/prometheus](https://github.com/prometheus/prometheus) | patch | `v3.11.2` → `v3.11.3` | --- ### Release Notes <details> <summary>prometheus/prometheus (quay.io/prometheus/prometheus)</summary> ### [`v3.11.3`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3): 3.11.3 / 2026-04-27 [Compare Source](prometheus/prometheus@v3.11.2...v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@​iiihaiii](https://github.com/iiihaiii) and [@​Ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#​18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#​18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#​18588](prometheus/prometheus#18588) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/303
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 1, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 1, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 1, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 1, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 1, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 1, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 1, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 1, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 2, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
May 2, 2026
##### [\`v3.11.3\`](https://github.com/prometheus/prometheus/releases/tag/v3.11.3) This release fixes mutiple security issues. We would like to thank the following people for the responsible disclosures: - Shadowbyte (4c1dr3aper) - Charlie Lewis for the Remote-Read snappy decode vulnerability. - Brett Gervasoni for the AzureAD OAuth `client_secret` vulnerability. - [@iiihaiii](https://github.com/iiihaiii) and [@ngocnn97](https://github.com/Ngocnn97) for the Old UI XSS vulnerability. - \[SECURITY] AzureAD remote write: Fix OAuth `client_secret` being exposed in plaintext via `/-/config` endpoint. GHSA-wg65-39gg-5wfj / CVE-2026-42151 [#18590](prometheus/prometheus#18590) - \[SECURITY] Remote-read: Reject snappy-compressed requests whose declared decoded length exceeds the decode limit. GHSA-8rm2-7qqf-34qm / CVE-2026-42154 [#18584](prometheus/prometheus#18584) - \[SECURITY] UI: Fix stored XSS via unescaped `le` label values in old UI heatmap chart tick labels. GHSA-fw8g-cg8f-9j28 [#18588](prometheus/prometheus#18588) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2 tasks
sidharth-jain23
added a commit
to hypertrace/service-framework
that referenced
this pull request
May 15, 2026
CVE-2026-42154 (CVSS 7.5) is a DoS vulnerability in the Prometheus server's /api/v1/read remote read endpoint (Go binary, fixed in v3.5.3 and v3.11.3). OWASP dependency-check incorrectly matches io.prometheus:simpleclient* Java jars against the same CPE (cpe:2.3:a:prometheus:prometheus) due to the shared "prometheus" name. The Java simpleclient library is a metrics instrumentation library and does not contain the affected remote read endpoint. This is a confirmed false positive per NVD (https://nvd.nist.gov/vuln/detail/CVE-2026-42154) which lists only the prometheus/prometheus Go server as affected. References: - NVD: https://nvd.nist.gov/vuln/detail/CVE-2026-42154 - Fix PRs: prometheus/prometheus#18584, prometheus/prometheus#18585 - Advisory: GHSA-8rm2-7qqf-34qm Co-Authored-By: Claude Opus 4.6 <[email protected]>
Deepanshu0703
pushed a commit
to hypertrace/service-framework
that referenced
this pull request
May 15, 2026
* chore: upgrade Jetty from 11.0.26 to 12.1.9 (ee10) Migrate from Jetty 11 to Jetty 12.1.9 using ee10 servlet compatibility layer: - Update hypertrace-bom catalog version to 0.3.79 (includes Jetty 12.1.9) - Update jakarta-servlet-api from 6.0.0 to 6.1.0 - Update servlet imports from o.e.j.servlet.* to o.e.j.ee10.servlet.* - Update servlets imports from o.e.j.servlets.* to o.e.j.ee10.servlets.* - Fix setVirtualHosts(String[]) to setVirtualHosts(List<String>) - Remove setShowServlet(false) (method removed in 12.1.x, behavior is now default) - Change ErrorHandler variable type to ErrorHandler from ee10 package - Regenerate all gradle lock files Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: suppress false positive CVE-2026-42154 for prometheus simpleclient CVE-2026-42154 (CVSS 7.5) is a DoS vulnerability in the Prometheus server's /api/v1/read remote read endpoint (Go binary, fixed in v3.5.3 and v3.11.3). OWASP dependency-check incorrectly matches io.prometheus:simpleclient* Java jars against the same CPE (cpe:2.3:a:prometheus:prometheus) due to the shared "prometheus" name. The Java simpleclient library is a metrics instrumentation library and does not contain the affected remote read endpoint. This is a confirmed false positive per NVD (https://nvd.nist.gov/vuln/detail/CVE-2026-42154) which lists only the prometheus/prometheus Go server as affected. References: - NVD: https://nvd.nist.gov/vuln/detail/CVE-2026-42154 - Fix PRs: prometheus/prometheus#18584, prometheus/prometheus#18585 - Advisory: GHSA-8rm2-7qqf-34qm Co-Authored-By: Claude Opus 4.6 <[email protected]> * Revert "fix: suppress false positive CVE-2026-42154 for prometheus simpleclient" This reverts commit f95e9d0. --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
vporoshok
added a commit
to deckhouse/prompp
that referenced
this pull request
May 18, 2026
Backport of upstream prometheus/prometheus#18584 (GHSA-8rm2-7qqf-34qm). DecodeReadRequest now checks snappy.DecodedLen before allocating, so a small crafted payload that claims a huge decoded size is rejected instead of triggering a multi-GB heap allocation per request. Signed-off-by: Bastrykov Evgeniy <[email protected]> Co-authored-by: Cursor <[email protected]>
Merged
4 tasks
|
Fix included in release 4.21.0-0.nightly-2026-07-13-235512 |
|
Fix included in release 4.20.0-0.nightly-2026-07-15-212908 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GHSA-8rm2-7qqf-34qm.
Which issue(s) does the PR fix:
Release notes for end users (ALL commits must be considered).
Reviewers should verify clarity and quality.