Skip to content

st: disconnect st-storage with xor2-encoding given planned experiments#18316

Merged
bwplotka merged 5 commits into
feature/start-timefrom
st-disconnect
Mar 19, 2026
Merged

st: disconnect st-storage with xor2-encoding given planned experiments#18316
bwplotka merged 5 commits into
feature/start-timefrom
st-disconnect

Conversation

@bwplotka

Copy link
Copy Markdown
Member

As discussed in #18062 (comment)

XOR2 has some potential changes planned cc @roidelapluie

To simplify I propose we split those flags for now, until XOR2 stabilizes.

Does this PR introduce a user-facing change?

NONE

@bwplotka
bwplotka requested a review from a team as a code owner March 17, 2026 21:33
@bwplotka
bwplotka requested review from carrieedwards, krajorama, mxinden and ywwg and removed request for a team March 17, 2026 21:33
@krajorama krajorama self-assigned this Mar 18, 2026
@krajorama
krajorama requested a review from roidelapluie March 18, 2026 07:30
Comment thread docs/feature_flags.md Outdated
Comment thread docs/feature_flags.md Outdated
Comment thread docs/feature_flags.md Outdated
Comment thread docs/feature_flags.md Outdated
bwplotka and others added 4 commits March 18, 2026 09:28
Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>

@krajorama krajorama left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwplotka
bwplotka merged commit 364d708 into feature/start-time Mar 19, 2026
48 of 49 checks passed
@bwplotka
bwplotka deleted the st-disconnect branch March 19, 2026 08:47
bwplotka added a commit that referenced this pull request Mar 19, 2026
…ncoding` (#18062)

* feat(tsdb/chunkenc): add float chunk format with start timestamp support


Signed-off-by: György Krajcsovits <[email protected]>

* optimize code path and layout

Signed-off-by: György Krajcsovits <[email protected]>

* make new format usable in head

Signed-off-by: György Krajcsovits <[email protected]>

* fix issue with seeking to last sample again

Signed-off-by: György Krajcsovits <[email protected]>

* fix iterator benchmark for chunks not supporting ST

Signed-off-by: György Krajcsovits <[email protected]>

* reduce footprint of the xoroptst chunk iterator object

It was 80 bytes with a lot of padding compared to the 56 bytes of the
original xor chunk iterator. Made it 64 bytes, tightly packed.

Signed-off-by: György Krajcsovits <[email protected]>

* Fix benchmark expectations on ST in interator

Signed-off-by: György Krajcsovits <[email protected]>

* add inclusive delta test case

Signed-off-by: György Krajcsovits <[email protected]>

* make testcases independent of order

Signed-off-by: György Krajcsovits <[email protected]>

* drop unused code

Signed-off-by: György Krajcsovits <[email protected]>

* Drop commented out line

Signed-off-by: György Krajcsovits <[email protected]>

* documentation

Signed-off-by: György Krajcsovits <[email protected]>

* Small simplification in the doc

Signed-off-by: György Krajcsovits <[email protected]>

* Add delta st inclusive test case for random vt

Signed-off-by: György Krajcsovits <[email protected]>

* Switch to delta of difference of st to prev t

from delta of delta of st.

Signed-off-by: György Krajcsovits <[email protected]>

* Write ST after T and V so we can write a single bit on the second sample

Signed-off-by: György Krajcsovits <[email protected]>

* verify chunk sample len function

Signed-off-by: György Krajcsovits <[email protected]>

* Reduce size of first st stored a little

Signed-off-by: György Krajcsovits <[email protected]>

* test the case where st equals the t

Signed-off-by: György Krajcsovits <[email protected]>

* add st equal t to bechmarks

Signed-off-by: György Krajcsovits <[email protected]>

* test(chunkenc): test that appender can contonue chunks

Test that initializing a chunk appender from an existing chunk
works correctly.

Signed-off-by: György Krajcsovits <[email protected]>

* fix(chunkenc): bug in initializing appender on existing chunk

Signed-off-by: György Krajcsovits <[email protected]>

* Add cases with jitter in the start time as well


Signed-off-by: György Krajcsovits <[email protected]>

* tsdb: ST-in-WAL: Counter implementation and benchmarks (#17671)

Initial implementation of #17790.
Only implements ST-per-sample for Counters. Tests and benchmarks updated.

Note: This increases the size of the RefSample object for all users, whether st-per-sample is turned on or not.

Signed-off-by: Owen Williams <[email protected]>

* refactor: sed enableStStorage/enableSTStorage

Signed-off-by: bwplotka <[email protected]>

* feat[scrape]: add ST parsing support to scrape AppenderV2 flow (#18103)

Signed-off-by: bwplotka <[email protected]>

* feat(tsdb): change head opt EnableSTStorage to atomic (#18107)

In downstream projects this needs to be set dynamically per tenant.

Signed-off-by: György Krajcsovits <[email protected]>

* Merge pull request #18108 from prometheus/bwplotka/fix

scrape: add tests for ST appending; add warnings for ST feature flag users around _created drop

* refact(tsdb): trivial rename (#18109)

Signed-off-by: György Krajcsovits <[email protected]>

* fix(tsdb): missing passing head option to wal/wbl write (#18113)

Signed-off-by: György Krajcsovits <[email protected]>

* feat(tsdb): allow using ST capable XOR chunks - retain format on read (#18013)

* feat(tsdb): allow appending to ST capable XOR chunk optionally

Only for float samples as of now.  Supports for in-order and out-of-order
samples.

Make sure that on readout the ST capable chunks are returned automatically.
When the chunks are returned as is, this is trivially true.
When a chunk needs to be re-coded due to deletion (tombstone) markers,
we take the encoding of the original chunk.
When a chunk needs to be created from overlapping chunks, we observe
whether ST is zero or not and create the new chunk based on that.

Signed-off-by: György Krajcsovits <[email protected]>

* fix test after merge

Signed-off-by: bwplotka <[email protected]>

* feat: RW2 sending ST support

Signed-off-by: bwplotka <[email protected]>

tmp

Signed-off-by: bwplotka <[email protected]>

* tests: test ST in a cheapest way possible

Signed-off-by: bwplotka <[email protected]>

* tests: add bench CLI recommended invokations

Signed-off-by: bwplotka <[email protected]>

* fixed tests after rebase

Signed-off-by: bwplotka <[email protected]>

* feat(chunkenc): replace xoroptst chunk encoding with xor2

XOR2 is based on #18238
With additional ST support.

Signed-off-by: György Krajcsovits <[email protected]>

* feat: add compliance RW sender test for agent

Signed-off-by: bwplotka <[email protected]>

* feat(agent): add support for appending ST

Signed-off-by: bwplotka <[email protected]>

* replace stray xoroptst words

Signed-off-by: György Krajcsovits <[email protected]>

* Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>

* post merge conflict fixes

Signed-off-by: bwplotka <[email protected]>

* feat(tsdb): register st_storage in feature API

Register the st-storage feature flag in the feature registry via
the TSDB options, consistent with how other TSDB features like
exemplar_storage and delayed_compaction are registered.

Signed-off-by: György Krajcsovits <[email protected]>
Coded with Claude Sonnet 4.6.

* Document xor2-encoding feature flag

Signed-off-by: Carrie Edwards <[email protected]>

* Add xor2-encoding feature flag

Signed-off-by: Carrie Edwards <[email protected]>

* Update CHANGELOG

Signed-off-by: Carrie Edwards <[email protected]>

* Fix linting

Signed-off-by: Carrie Edwards <[email protected]>

* Remove setting of xor2 encoding option in db open

Signed-off-by: Carrie Edwards <[email protected]>

* Fix tests

Signed-off-by: Carrie Edwards <[email protected]>

* Fix linting

Signed-off-by: Carrie Edwards <[email protected]>

* Update feature flag description

Signed-off-by: Carrie Edwards <[email protected]>

* Update comments and feature flag description

Signed-off-by: Carrie Edwards <[email protected]>

* Update documentation for st-storage feature

Signed-off-by: Carrie Edwards <[email protected]>

* st: disconnect st-storage with xor2-encoding given planned experiments (#18316)

* st: disconnect st-storage with xor2-encoding given planned experiments

Signed-off-by: bwplotka <[email protected]>

* Update docs/feature_flags.md

Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>

* Update docs/feature_flags.md

Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>

* Update docs/feature_flags.md

Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>

* Update docs/feature_flags.md

Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>

---------

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: George Krajcsovits <[email protected]>

---------

Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Aleksandr Smirnov <[email protected]>
Signed-off-by: Mohammad Abbasi <[email protected]>
Signed-off-by: matt-gp <[email protected]>
Signed-off-by: Ian Kerins <[email protected]>
Signed-off-by: SuperQ <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: ffgan <[email protected]>
Signed-off-by: Patryk Prus <[email protected]>
Signed-off-by: Owen Williams <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: 3Juhwan <[email protected]>
Signed-off-by: Sammy Tran <[email protected]>
Signed-off-by: Casie Chen <[email protected]>
Signed-off-by: Dan Cech <[email protected]>
Signed-off-by: kakabisht <[email protected]>
Signed-off-by: Jeanette Tan <[email protected]>
Signed-off-by: Divyansh Mishra <[email protected]>
Signed-off-by: Varun Chawla <[email protected]>
Signed-off-by: Martin Valiente Ainz <[email protected]>
Signed-off-by: Kyle Eckhart <[email protected]>
Signed-off-by: Julien Pivotto <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Linas Medziunas <[email protected]>
Signed-off-by: Björn Rabenstein <[email protected]>
Signed-off-by: beorn7 <[email protected]>
Signed-off-by: Sayuru <[email protected]>
Signed-off-by: Matt <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Carrie Edwards <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: Ganesh Vernekar <[email protected]>
Co-authored-by: Bryan Boreham <[email protected]>
Co-authored-by: Sasha <[email protected]>
Co-authored-by: Mohammad Abbasi <[email protected]>
Co-authored-by: matt-gp <[email protected]>
Co-authored-by: Ian Kerins <[email protected]>
Co-authored-by: SuperQ <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arve Knudsen <[email protected]>
Co-authored-by: Julien <[email protected]>
Co-authored-by: ffgan <[email protected]>
Co-authored-by: Patryk Prus <[email protected]>
Co-authored-by: Ganesh Vernekar <[email protected]>
Co-authored-by: Joe Adams <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Owen Williams <[email protected]>
Co-authored-by: 3Juhwan <[email protected]>
Co-authored-by: Casie Chen <[email protected]>
Co-authored-by: Dan Cech <[email protected]>
Co-authored-by: hridyesh bisht <[email protected]>
Co-authored-by: zenador <[email protected]>
Co-authored-by: Divyansh Mishra <[email protected]>
Co-authored-by: Varun Chawla <[email protected]>
Co-authored-by: Martin Valiente Ainz <[email protected]>
Co-authored-by: Kyle Eckhart <[email protected]>
Co-authored-by: Matthieu MOREL <[email protected]>
Co-authored-by: Linas Medžiūnas <[email protected]>
Co-authored-by: Björn Rabenstein <[email protected]>
Co-authored-by: beorn7 <[email protected]>
Co-authored-by: Sayuru <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Carrie Edwards <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants