Skip to content

histograms: BenchmarkFloatHistogramAdd#18248

Merged
krajorama merged 2 commits into
prometheus:mainfrom
linasm:benchmark-float-histogram-add
Mar 17, 2026
Merged

histograms: BenchmarkFloatHistogramAdd#18248
krajorama merged 2 commits into
prometheus:mainfrom
linasm:benchmark-float-histogram-add

Conversation

@linasm

@linasm linasm commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Mainly for demonstrating the difference between FloatHistogram.Add and FloatHistogram.KahanAdd.

BenchmarkFloatHistogramAdd/Add
BenchmarkFloatHistogramAdd/Add-10         	   64574	     18312 ns/op	       0 B/op	       0 allocs/op
BenchmarkFloatHistogramAdd/KahanAdd
BenchmarkFloatHistogramAdd/KahanAdd-10    	   30944	     38313 ns/op	     800 B/op	       3 allocs/op

NONE

@linasm
linasm requested review from a team, beorn7 and krajorama as code owners March 6, 2026 14:37
@linasm linasm mentioned this pull request Mar 6, 2026
Closed
@krajorama
krajorama requested a review from bboreham March 6, 2026 14:56
@linasm linasm mentioned this pull request Mar 6, 2026
Merged
@linasm
linasm force-pushed the benchmark-float-histogram-add branch from ba2e359 to 4aeb82b Compare March 7, 2026 08:16
krajorama
krajorama reviewed Mar 10, 2026
View reviewed changes
Comment thread model/histogram/float_histogram_test.go Outdated
Comment thread model/histogram/float_histogram_test.go Outdated
@krajorama krajorama self-assigned this Mar 10, 2026
@linasm
BenchmarkFloatHistogramAdd
89c46d4 
Signed-off-by: Linas Medziunas <[email protected]>
@linasm
linasm force-pushed the benchmark-float-histogram-add branch from 4aeb82b to 89c46d4 Compare March 10, 2026 13:01
@linasm
linasm requested a review from krajorama March 10, 2026 13:03
krajorama
krajorama approved these changes Mar 10, 2026
View reviewed changes

@krajorama krajorama left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

bwplotka
bwplotka approved these changes Mar 11, 2026
View reviewed changes

@bwplotka bwplotka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread model/histogram/float_histogram_test.go Outdated
@linasm
Format
7b4aa79 
Signed-off-by: Linas Medziunas <[email protected]>
@linasm
linasm force-pushed the benchmark-float-histogram-add branch from 24f6fa8 to 7b4aa79 Compare March 17, 2026 12:50
@krajorama
krajorama merged commit c532b65 into prometheus:main Mar 17, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwplotka bwplotka bwplotka approved these changes
@krajorama krajorama krajorama approved these changes
@beorn7 beorn7 Awaiting requested review from beorn7
@bboreham bboreham Awaiting requested review from bboreham

Assignees

@krajorama krajorama

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linasm @bwplotka @krajorama