Merge main to feature/start-time#18171
Merged
Merged
Conversation
Signed-off-by: 3Juhwan <[email protected]> Signed-off-by: Sammy Tran <[email protected]>
Signed-off-by: Casie Chen <[email protected]>
Signed-off-by: Dan Cech <[email protected]>
Signed-off-by: kakabisht <[email protected]>
testing: enable experimental functions in promql benchmarks
* Add new test cases for multiple name matchers in PromQL info function * Fix handling of multiple name matchers in PromQL info function --------- Signed-off-by: Jeanette Tan <[email protected]>
Signed-off-by: Divyansh Mishra <[email protected]>
…am write paths The OTLP write handler and the PRW v2 histogram append path were missing ErrTooOldSample from their error type checks, causing these errors to fall through to the default case and return HTTP 500 Internal Server Error. This triggered unnecessary retries in OTLP clients like the Python SDK. The PRW v1 write handler (line 115) and the PRW v2 sample append path (line 377) already correctly handle ErrTooOldSample as a 400, and this change makes the remaining paths consistent. Also adds ErrTooOldSample to the v1 sample/histogram log checks so these errors are properly logged instead of silently returned. Fixes #16645 Signed-off-by: Varun Chawla <[email protected]>
…data points (#18056) In addHistogramDataPoints, exemplars assigned to the +Inf bucket of one data point were carried over into the _sum and _count Append calls of the next data point via the shared appOpts. Clear appOpts.Exemplars at the start of each loop iteration to restore the nil-exemplar semantics that existed before the AppenderV2 migration. Signed-off-by: Arve Knudsen <[email protected]>
Replace polling loops (for range 100 { time.Sleep }) with explicit
db.Compact() calls after disabling background compaction, eliminating
CI flakiness on slow machines. Also fix incorrect overlap assertions
that were checking the wrong direction (LessOrEqual -> GreaterOrEqual).
Signed-off-by: Arve Knudsen <[email protected]>
Convert all timing-sensitive subtests of TestAsyncRuleEvaluation to use synctest for deterministic testing. This fixes flakiness on Windows caused by timer granularity and scheduling variance. The timing assertions are preserved using synctest's fake time, which allows accurate verification of sequential vs concurrent execution timing without relying on wall-clock time. Fixes #17961 Signed-off-by: Arve Knudsen <[email protected]>
He's been participating in the bug scrub for a year and provides reviews all over the code base. Also fix name spelling. Signed-off-by: György Krajcsovits <[email protected]>
… rules (#18097) Both are regressions from the parser refactoring in #17977. - Fixes #18092 - Fixes #18093 Signed-off-by: Martin Valiente Ainz <[email protected]>
tsdb:Optimize LabelValues API performance (#14551)
#17598) * RemoveTmpDirs function to tsdbutil * Refactor db to use RemoveTmpDirs and no longer cleanup checkpoint tmp dirs * Use RemoveTmpDirs in wlog checkpoint to cleanup all checkpoint tmp folders * Add tests for RemoveTmpDirs * Ensure db.Open will still cleanup extra temporary checkpoints Signed-off-by: Kyle Eckhart <[email protected]>
tsdb: fix flaky TestBlockRanges by using explicit compaction
…ample fix: handle ErrTooOldSample as 400 in OTLP and v2 histogram write paths
test(web): Wait for server ready instead of sleeping 5 seconds.
Since our minimum supported go version is now go 1.25, we can use wg.Go. Signed-off-by: Julien Pivotto <[email protected]>
chore(lint): enable wg.Go
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Linas Medziunas <[email protected]> Signed-off-by: Björn Rabenstein <[email protected]> Signed-off-by: beorn7 <[email protected]> Co-authored-by: Björn Rabenstein <[email protected]> Co-authored-by: beorn7 <[email protected]>
chore: enable staticcheck linter and update golangci-lint to 2.10.1
Signed-off-by: Sayuru <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: bwplotka <[email protected]>
model/labels: improve performance for regex alternations of form .*literal1.*|.*literal2.*
…18128) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… to v1.37.0 (#18158) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…8157) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* AWS SD: Elasticache This change adds Elasticache to the AWS SD. Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Matt <[email protected]> --------- Signed-off-by: Matt <[email protected]> Co-authored-by: Ben Kochie <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… v1.3.3 (#18137) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: bwplotka <[email protected]>
bwplotka
requested review from
a team,
alexgreenbank,
codesome,
cstyan,
jesusvazquez and
tomwilkie
as code owners
February 23, 2026 10:03
bwplotka
requested review from
ArthurSens,
Nexucis,
aknuds1,
dgl,
juliusv,
matt-gp,
roidelapluie and
sysadmind
as code owners
February 23, 2026 10:03
Member
Author
|
The only failure comes from flakiness around OOM in rare arch, we know about this: runtime: out of memory: cannot allocate 327155712-byte block (3396042752 in use) goroutine 10352 gp=0xcc49d48 m=3 mp=0xbc6b008 [running, synctest bubble 2]: |
Member
Author
|
Merging given the @ywwg approve in #18126 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-pull failed: #18126
One commit on top fixes breaking changes (new test).
Got approve from @ywwg on the similar PR without a tiny fix commit #18126 (review)
NOTE: Use merge submit
Does this PR introduce a user-facing change?