Merge remote-tracking branch 'origin/main' into feature/start-time#18071
Merged
Conversation
Add regression test for the bug where avg_over_time with a single histogram sample would produce +Inf count/sum and NaN zero bucket due to division by zero. The test verifies that both regular exponential histograms and native histograms with custom buckets (NHCB) correctly return the histogram unchanged when averaging a single sample. Signed-off-by: Jeanette Tan <[email protected]>
avg_over_time would produce +Inf count/sum and NaN zero bucket when averaging a single histogram, because the count variable was initialized to 0 instead of 1. This caused a division by zero at the end of the function. The float version of avg_over_time already correctly initializes count to 1, this change makes the histogram version consistent with that. Signed-off-by: Jeanette Tan <[email protected]>
…al flags Parser configuration is now per-engine/API/loader and no longer uses package-level flags, so behavior is consistent and tests don't rely on save/restore of global variables. Signed-off-by: Martin Valiente Ainz <[email protected]>
Signed-off-by: Martin Valiente Ainz <[email protected]>
Signed-off-by: Martin Valiente Ainz <[email protected]>
Signed-off-by: Martin Valiente Ainz <[email protected]>
…tion PromQL: Refactor parser to use instance configuration instead of global flags
promql: fix avg_over_time for single native histogram
Fail Go mod check if the `go` directive in `go.mod` is newer than the currently supported Go versions. Signed-off-by: SuperQ <[email protected]>
Add CI check for Go version support
… version Signed-off-by: Julien Pivotto <[email protected]>
chore: Check that previous go version check actually uses previous go version
With native histograms being a stable feature, we should get rid of this special line, which isn't really mapping maintainership to a subtree, but to something that is all over the codebase. Additionally, @beorn7 will soon retire from the project, so we needed to remove him from this file anyway. Signed-off-by: beorn7 <[email protected]>
Remove special native histogram line from MAINTAINERS.md
ywwg
marked this pull request as ready for review
February 12, 2026 18:19
Member
Author
|
feels like flaky tests to me |
Member
|
Hm I think it's our changes that trigger one of those in general (not this PR though specifically)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.