tests: Unify TestDiskFillingUpAfterDisablingOOO and avoid hiding errors#18017
Merged
tests: Unify TestDiskFillingUpAfterDisablingOOO and avoid hiding errors#18017
Conversation
Signed-off-by: bwplotka <[email protected]>
bwplotka
requested review from
a team,
codesome,
jesusvazquez and
krajorama
as code owners
This was referenced Feb 5, 2026
Signed-off-by: bwplotka <[email protected]>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…rs (prometheus#18017) * tests: Unify TestDiskFillingUpAfterDisablingOOO and avoid hiding errors Signed-off-by: bwplotka <[email protected]> * addressed comments Signed-off-by: bwplotka <[email protected]> --------- Signed-off-by: bwplotka <[email protected]> Signed-off-by: Will Bollock <[email protected]>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…rs (prometheus#18017) * tests: Unify TestDiskFillingUpAfterDisablingOOO and avoid hiding errors Signed-off-by: bwplotka <[email protected]> * addressed comments Signed-off-by: bwplotka <[email protected]> --------- Signed-off-by: bwplotka <[email protected]>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…rs (prometheus#18017) * tests: Unify TestDiskFillingUpAfterDisablingOOO and avoid hiding errors Signed-off-by: bwplotka <[email protected]> * addressed comments Signed-off-by: bwplotka <[email protected]> --------- Signed-off-by: bwplotka <[email protected]>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…rs (prometheus#18017) * tests: Unify TestDiskFillingUpAfterDisablingOOO and avoid hiding errors Signed-off-by: bwplotka <[email protected]> * addressed comments Signed-off-by: bwplotka <[email protected]> --------- Signed-off-by: bwplotka <[email protected]>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…rs (prometheus#18017) * tests: Unify TestDiskFillingUpAfterDisablingOOO and avoid hiding errors Signed-off-by: bwplotka <[email protected]> * addressed comments Signed-off-by: bwplotka <[email protected]> --------- Signed-off-by: bwplotka <[email protected]>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…rs (prometheus#18017) * tests: Unify TestDiskFillingUpAfterDisablingOOO and avoid hiding errors Signed-off-by: bwplotka <[email protected]> * addressed comments Signed-off-by: bwplotka <[email protected]> --------- Signed-off-by: bwplotka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses on #17941 (comment)
Does this PR introduce a user-facing change?