Skip to content

OpenAPI: Add support for stats#17975

Merged
roidelapluie merged 1 commit intoprometheus:mainfrom
roidelapluie:roidelapluie/openapistats
Feb 5, 2026
Merged

OpenAPI: Add support for stats#17975
roidelapluie merged 1 commit intoprometheus:mainfrom
roidelapluie:roidelapluie/openapistats

Conversation

@roidelapluie
Copy link
Copy Markdown
Member

@roidelapluie roidelapluie commented Jan 30, 2026

An oversight on the OpenAPI specification; which did not include stats.

Which issue(s) does the PR fix:

Does this PR introduce a user-facing change?

NONE

An oversight on the OpenAPI specification; which did not include stats.

Signed-off-by: Julien Pivotto <[email protected]>
@roidelapluie roidelapluie requested a review from a team as a code owner January 30, 2026 13:22
@krajorama krajorama requested review from krajorama and removed request for tomwilkie January 30, 2026 13:28
Copy link
Copy Markdown
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Suggest follow-up to include as example so visible without looking at the schema.

@roidelapluie roidelapluie merged commit 37058a3 into prometheus:main Feb 5, 2026
53 of 55 checks passed
songy23 pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Mar 12, 2026
#### Description

Updates Prometheus dependencies to `v0.310.0`.

The main upstream changes were:
- `scrape.NewManager` now requires the new constructor shape with
`appendable` and `appendableV2`, and rejects calls where both are `nil`
or both are set.
- Upstream PR:
[prometheus/prometheus#17872](prometheus/prometheus#17872)
- `web/api/v1.NewAPI` gained an `AppendableV2` argument and new trailing
OpenAPI-related options.
- Upstream PRs:
[prometheus/prometheus#17825](prometheus/prometheus#17825),
[prometheus/prometheus#17975](prometheus/prometheus#17975)

In this PR, I'm keeping the appenderv1 in place; the adoption of
appenderv2 should be done in as a separate task

---------

Signed-off-by: Arthur Silva Sens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants