Skip to content

Comments

refactor(ui): Remove explicit any from globals#17832

Merged
juliusv merged 1 commit intoprometheus:mainfrom
minyeong981:ui/typings-global-jquery-moment
Jan 27, 2026
Merged

refactor(ui): Remove explicit any from globals#17832
juliusv merged 1 commit intoprometheus:mainfrom
minyeong981:ui/typings-global-jquery-moment

Conversation

@minyeong981
Copy link
Contributor

@minyeong981 minyeong981 commented Jan 10, 2026 •
edited
Loading

Which issue(s) does the PR fix:

NONE

Does this PR introduce a user-facing change?

NONE

What this PR does

  • Removes explicit any usage from globals.ts.
  • Aligns runtime global assignments with existing ambient typings for jQuery and moment.

Why this change is needed

  • The react-app UI already defines global typings for jQuery and related libraries.
  • This change connects those typings to the actual runtime assignments, improving type safety without changing runtime behavior.

Testing

  • Verified that the React UI builds successfully.
  • Verified that the UI renders as expected.

@minyeong981 minyeong981 requested a review from juliusv as a code owner January 10, 2026 15:57
@juliusv
Copy link
Member

juliusv commented Jan 27, 2026

Thanks! 👍

@juliusv juliusv merged commit 304dcdf into prometheus:main Jan 27, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusv juliusv juliusv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@minyeong981 @juliusv