Skip to content

chore(deps): bump github.com/hetznercloud/hcloud-go/v2 from 2.32.0 to 2.33.0#17762

Merged
aknuds1 merged 3 commits into
mainfrom
dependabot/go_modules/github.com/hetznercloud/hcloud-go/v2-2.33.0
Jan 7, 2026
Merged

chore(deps): bump github.com/hetznercloud/hcloud-go/v2 from 2.32.0 to 2.33.0#17762
aknuds1 merged 3 commits into
mainfrom
dependabot/go_modules/github.com/hetznercloud/hcloud-go/v2-2.33.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jan 1, 2026 •
edited by aknuds1
Loading

Copy link
Copy Markdown
Contributor

Bumps github.com/hetznercloud/hcloud-go/v2 from 2.32.0 to 2.33.0.

NB: server.Datacenter is deprecated in favor of server.Location. As a result, __meta_hetzner_datacenter now contains the location name (e.g., "fsn1") instead of the datacenter name (e.g., "fsn1-dc8"), making it equivalent to __meta_hetzner_hcloud_datacenter_location. The label is kept for backwards compatibility with existing relabel configs. @mmorel-35 I think you've been working on discovery/hetzner, do you think the change to __meta_hetzner_datacenter is OK?

[CHANGE] Hetzner SD: The `__meta_hetzner_datacenter` label will be removed in the next minor release, this due to upstream no longer sending the datacenter property from July 1st 2026
Release notes

Sourced from github.com/hetznercloud/hcloud-go/v2's releases.

v2.33.0

Phasing out datacenters in Primary IPs and Servers

We added a new location property to the request body and response of Servers and Primary IPs. The same data was previously present under datacenter.location.

We deprecated the datacenter property in the request body and response of Servers and Primary IPs. The removal will happen after 1 July 2026.

See our changelog for more details.

Features

  • add update rrset records action to zone client (#773)
  • deprecate datacenter in primary ips and servers (#793)
  • default to max per page value in AllWithOpts (#794)
Changelog

Sourced from github.com/hetznercloud/hcloud-go/v2's changelog.

v2.33.0

Features

  • add update rrset records action to zone client (#773)
  • deprecate datacenter in primary ips and servers (#793)
  • default to max per page value in AllWithOpts (#794)
Commits
  • 6684746 chore(main): release v2.33.0 (#779)
  • f4ecfa7 feat: default to max per page value in AllWithOpts (#794)
  • 0922bba feat: deprecate datacenter in primary ips and servers (#793)
  • 6afa559 deps: update actions/cache action to v5 (#789)
  • 5b818ce chore: revert Storage Box support no longer experimental (#788)
  • e4d7324 ci: remove stale bot workflow (#787)
  • cf0f52e deps: update pre-commit hook golangci/golangci-lint to v2.7.2 (#785)
  • 60400d7 deps: update golang.org/x/ (#786)
  • 110bd4d deps: update pre-commit hook golangci/golangci-lint to v2.7.1 (#784)
  • daf9cf4 feat: Storage Box support no longer experimental (#783)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 1, 2026
@aknuds1
aknuds1 force-pushed the dependabot/go_modules/github.com/hetznercloud/hcloud-go/v2-2.33.0 branch 2 times, most recently from e2e0c90 to cb0d3e4 Compare January 4, 2026 15:23
@aknuds1
aknuds1 requested review from brancz and roidelapluie January 4, 2026 15:26
@roidelapluie

roidelapluie commented Jan 6, 2026

Copy link
Copy Markdown
Member

Can we keep the label backwards compatible?

@aknuds1

aknuds1 commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Can we keep the label backwards compatible?

Do you mean the __meta_hetzner_datacenter label value @roidelapluie? I don't see how it's possible, unless we stay on the deprecated server.Datacenter field (will be removed in July). Do you have something else in mind?

@roidelapluie

roidelapluie commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I'd say: keep the same value for now, announce in CHANGELOG.md that we will remove the label in the next minor release due to upstream removing it.

@aknuds1

aknuds1 commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

I'd say: keep the same value for now, announce in CHANGELOG.md that we will remove the label in the next minor release due to upstream removing it.

@roidelapluie Sounds sensible, will take care of it 👍

@aknuds1

aknuds1 commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

@roidelapluie I reverted the code change, and just disabled linting of the relevant lines. Does the release note look like what you had in mind? How do we make sure that the change is actually done in the next minor release?

dependabot Bot and others added 3 commits January 6, 2026 17:25
@dependabot @aknuds1
chore(deps): bump github.com/hetznercloud/hcloud-go/v2
8fe0b8f 
Bumps [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) from 2.32.0 to 2.33.0.
- [Release notes](https://github.com/hetznercloud/hcloud-go/releases)
- [Changelog](https://github.com/hetznercloud/hcloud-go/blob/main/CHANGELOG.md)
- [Commits](hetznercloud/hcloud-go@v2.32.0...v2.33.0)

---
updated-dependencies:
- dependency-name: github.com/hetznercloud/hcloud-go/v2
  dependency-version: 2.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@aknuds1
fix(hetzner): migrate from deprecated server.Datacenter to server.Loc…
714a2e1 
…ation

The hcloud-go v2.33.0 deprecates server.Datacenter in favor of
server.Location. This updates the hcloud discovery to use the new API.

Note: __meta_hetzner_datacenter now contains the location name (e.g.,
"fsn1") instead of the datacenter name (e.g., "fsn1-dc8"), making it
equivalent to __meta_hetzner_hcloud_datacenter_location. The label is
kept for backwards compatibility with existing relabel configs.

Signed-off-by: Arve Knudsen <[email protected]>
@aknuds1
Use deprecated value for now
317fc81 
Signed-off-by: Arve Knudsen <[email protected]>
@aknuds1
aknuds1 force-pushed the dependabot/go_modules/github.com/hetznercloud/hcloud-go/v2-2.33.0 branch from 745c470 to 317fc81 Compare January 6, 2026 16:26
roidelapluie
roidelapluie approved these changes Jan 7, 2026
View reviewed changes

@roidelapluie roidelapluie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM

I'd create an issue for the next release (you can assign to me).

@aknuds1 aknuds1 mentioned this pull request Jan 7, 2026
Closed
@aknuds1

aknuds1 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

I made an issue @roidelapluie. Thanks!

@aknuds1
aknuds1 merged commit 99c8351 into main Jan 7, 2026
45 of 46 checks passed
@aknuds1
aknuds1 deleted the dependabot/go_modules/github.com/hetznercloud/hcloud-go/v2-2.33.0 branch January 7, 2026 12:21
@jooola jooola mentioned this pull request Jan 13, 2026
Merged
@machine424 machine424 mentioned this pull request Mar 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes
@roidelapluie roidelapluie roidelapluie approved these changes
@brancz brancz Awaiting requested review from brancz

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roidelapluie @aknuds1