storage-prw: send Unit and Type when feature flag is enabled#17033
Merged
bwplotka merged 24 commits intoprometheus:mainfrom Aug 29, 2025
Merged
Conversation
perebaj
commented
Aug 10, 2025
|
Hey @perebaj, I think you forget to sign off your commit DCO Failed !! In checks |
Contributor
Author
Thanks. I will take a look. |
ArthurSens
reviewed
Aug 12, 2025
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
Looks like you're in a good direction, besides the test 😛
Also, probably a good idea to build prometheus (make build), start it and test sending data to the prometheusremotewrite receiver to see if things work as you expect
perebaj
force-pushed
the
chore/send-unit-type-when-feature-flag-enabled
branch
from
5ee4585 to
87af644
Compare
perebaj
changed the title
bwplotka
reviewed
Aug 21, 2025
perebaj
force-pushed
the
chore/send-unit-type-when-feature-flag-enabled
branch
from
8deaa9a to
4273b78
Compare
perebaj
requested review from
dgl,
jesusvazquez and
roidelapluie
as code owners
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Member
|
Can you rebase/squash commits to only relevant ones? |
perebaj
force-pushed
the
chore/send-unit-type-when-feature-flag-enabled
branch
from
417ad72 to
27b045c
Compare
bwplotka
reviewed
Aug 22, 2025
bwplotka
reviewed
Aug 22, 2025
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
bwplotka
approved these changes
Aug 28, 2025
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks for iterating this!
There are bunch of nits to make it perfect, but otherwise LGTM!
Signed-off-by: perebaj <[email protected]>
…nitLabels Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
Signed-off-by: perebaj <[email protected]>
ArthurSens
reviewed
Aug 28, 2025
Signed-off-by: perebaj <[email protected]>
ArthurSens
approved these changes
Aug 28, 2025
bwplotka
approved these changes
Aug 29, 2025
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Amazing! Thanks for prompt work on this 💪🏽
Signed-off-by: Bartlomiej Plotka <[email protected]>
siavashs
pushed a commit
to siavashs/prometheus
that referenced
this pull request
Aug 29, 2025
…ed (prometheus#17033) * chore: send Unit and Type when feature flag is enabled Signed-off-by: perebaj <[email protected]> * remove unused code and comments Signed-off-by: perebaj <[email protected]> * remove unreal scenario Signed-off-by: perebaj <[email protected]> * remove unused if Signed-off-by: perebaj <[email protected]> * remove unused labels Signed-off-by: perebaj <[email protected]> * linter Signed-off-by: perebaj <[email protected]> * enable type and unit through remotewrite config Signed-off-by: perebaj <[email protected]> * remove test comment and capture type and unit when flag is enabled Signed-off-by: perebaj <[email protected]> * gofumpt Signed-off-by: perebaj <[email protected]> * modelTypeToWriteV2Type Signed-off-by: perebaj <[email protected]> * use NewMetadataFromLabels Signed-off-by: perebaj <[email protected]> * capture feature flag from main Signed-off-by: perebaj <[email protected]> * simplifying logic Signed-off-by: perebaj <[email protected]> * remove unused function Signed-off-by: perebaj <[email protected]> * formatting code Signed-off-by: perebaj <[email protected]> * gofumpt Signed-off-by: perebaj <[email protected]> * remove public var: EnableTypeAndUnitLabels Signed-off-by: perebaj <[email protected]> * remove enableTypeAndUnitLabels from TestPopulateV2TimeSeries_typeAndUnitLabels Signed-off-by: perebaj <[email protected]> * remove enableTypeAndUnitLabels from main Signed-off-by: perebaj <[email protected]> * use schema helper to populate metadata Signed-off-by: perebaj <[email protected]> * remove metadata since nil is the default value Signed-off-by: perebaj <[email protected]> * add TestPopulateV2TimeSeries_UnexpectedMetadata Signed-off-by: perebaj <[email protected]> * Update storage/remote/queue_manager_test.go Signed-off-by: Bartlomiej Plotka <[email protected]> --------- Signed-off-by: perebaj <[email protected]> Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]>
siavashs
pushed a commit
to siavashs/prometheus
that referenced
this pull request
Aug 29, 2025
…is enabled (prometheus#17033)" This reverts commit c808a71.
siavashs
pushed a commit
to siavashs/prometheus
that referenced
this pull request
Aug 29, 2025
… is enabled (prometheus#17033)" This reverts commit f5fab47.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to this thread we would like to send type and unit data to be accessed on the PRW2. This will unlock some issues that we are facing on the OTEL side. This because some metrics can be sent without type even if the feature flag is set, causing errors in the parsing process.
Related issue on otel-collector-contrib -> open-telemetry/opentelemetry-collector-contrib#41840 (comment)
Which issue(s) does the PR fix:
Partially fixes: #16610.
Does this PR introduce a user-facing change?