feature: type-and-unit-labels (PROM-39 implementation) #16228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
type-and-unit-labels
branch
from
4858450 to
e50a616
Compare
bwplotka
force-pushed
the
type-and-unit-labels
branch
2 times, most recently
from
d352464 to
0a274f5
Compare
bwplotka
added a commit
to prometheus/proposals
that referenced
this pull request
Mar 18, 2025
PR with the implementation is also available: prometheus/prometheus#16228 Signed-off-by: bwplotka <[email protected]>
bwplotka
force-pushed
the
type-and-unit-labels
branch
from
0a274f5 to
87f94b0
Compare
bwplotka
force-pushed
the
type-and-unit-labels
branch
3 times, most recently
from
7417d2c to
69ccac6
Compare
ArthurSens
reviewed
Mar 20, 2025
Member
There was a problem hiding this comment.
Not in this PR, but in the same feature flag we should:
- Update UI as proposed in the proposal
Just to clarify what you mean here. Do you want this PR to hide type and unit labels, and the following PR will have that checkbox to show them? Or do you want to leave hiding type and unit to the following PR as well?
I'm asking because while testing, I noticed that those labels are present during query-time
ywwg
reviewed
Mar 21, 2025
Member
Author
|
Will adress all comments after KubeCon! Thanks for reviewing! |
bwplotka
force-pushed
the
type-and-unit-labels
branch
from
69ccac6 to
d97435b
Compare
Member
Author
|
Thanks for the epic reviews @ArthurSens @ywwg ! I am progressing on the rebase and update, currently cannot decide on naming of that internal group of metadata/metric family/metric descriptor/metric desc, will play around those... 🙈
As in our updated proposal I propose to not change UI for now, so we can talk about this later. Personally I think UI option for hiding those is nice, but majority of ecosystem will have those labels "exposed" anyway, so it's not a helping a lot, thus not a blocker/game changer. |
ArthurSens
reviewed
Apr 30, 2025
Member
Author
|
Thanks for helping @ArthurSens -- what's next for this? I believe we need to add some test cases for proto and OM parsing and what we expect from the storage (if we don't have this already). Then also that PromQL engine warning I ended up with "MetricDescriptor" for the internal structure -- might be good enough. |
Member
Sounds good, I want to find time to work on this during this week or during the next one at max
I was talking with @carrieedwards, and she volunteered to tackle this part since PromQL Engine is completely alien to me 😭. She is busy for a while though; she is presenting at GrafanaCon this week and will be at an offsite in the following week. Could you confirm, Carrie?
Looks good to me :) |
bwplotka
changed the title
bwplotka
changed the title
Contributor
Yes, I will take a look at this next week or the week after! |
Member
Author
|
Cool, amazing! I will try to progress in the meantime. I decided to refactor the weird "MetricDescriptor" into schema.Metadata -- might be more clear. I will add test cases and I propose we tackle PromQL engine warning on mixed units/types in separate PR (: |
bwplotka
force-pushed
the
type-and-unit-labels
branch
3 times, most recently
from
009c8d9 to
73100ba
Compare
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: bwplotka <[email protected]>
bwplotka
force-pushed
the
type-and-unit-labels
branch
from
7cad4e1 to
5e91463
Compare
Signed-off-by: bwplotka <[email protected]>
bwplotka
force-pushed
the
type-and-unit-labels
branch
from
d6d166b to
a86b297
Compare
ArthurSens
approved these changes
May 16, 2025
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
I have two nits, but LGTM!
Signed-off-by: bwplotka <[email protected]>
8 tasks
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
May 27, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Jun 2, 2025
* Update mimir-prometheus * Replace references to `InstanceName` removed in prometheus/prometheus#16228 * Fix native histogram mangling behaviour to be compatible with prometheus/prometheus#16565 * Make build tags consistent with Prometheus * Update MQE tests to match upstream * Reinstate test cases that were skipped due to upstream issues * Bring in changes from grafana/mimir-prometheus#880 * Add changelog entries * Regenerate OTLP files * Fix breaking change * Update upstream tests
This was referenced Jun 2, 2025
roidelapluie
pushed a commit
to roidelapluie/proposals
that referenced
this pull request
Jun 10, 2025
PR with the implementation is also available: prometheus/prometheus#16228 Signed-off-by: bwplotka <[email protected]>
2 tasks
This was referenced Aug 8, 2025
coleenquadros
added a commit
to stolostron/prometheus
that referenced
this pull request
Sep 10, 2025
* MAINTAINERS: add Jan-Otto Kröpke as an discovery/azure maintainer Signed-off-by: Jan-Otto Kröpke <[email protected]> * [REFACTOR] PromQL: DRY `stddev` and `stdvar` functions (#16451) * DRY stddev and stdvar --------- Signed-off-by: Neeraj Gartia <[email protected]> * feat: Support 'NoTranslation' mode in OTLP endpoint (#16441) * feat: Support 'NoTranslation' mode in OTLP endpoint Signed-off-by: Arthur Silva Sens <[email protected]> --------- Signed-off-by: Arthur Silva Sens <[email protected]> * promql: histogram_fraction for bucket histograms (#16095) * promql: histogram_fraction for bucket histograms This PR extends the histogram_fraction function to also work with classic bucket histograms. This is beneficial because it allows expressions like sum(increase(my_bucket{le="0.5"}[10m]))/sum(increase(my_total[10m])) to be written without knowing the actual values of the "le" label, easing the transition to native histograms later on. It also feels natural since histogram_quantile also can deal with classic histograms. Signed-off-by: Michael Hoffmann <[email protected]> * promql: histogram_fraction for bucket histograms * Add documentation and reduce code duplication * Fix a bug in linear interpolation between bucket boundaries * Add more PromQL tests Signed-off-by: Michael Hoffmann <[email protected]> * Update docs/querying/functions.md Co-authored-by: Björn Rabenstein <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]> --------- Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]> Co-authored-by: Björn Rabenstein <[email protected]> * Add primitive support for ingesting OTLP delta metrics as-is (#16360) * Add simple delta support Signed-off-by: Fiona Liao <[email protected]> * Rename delta2cumulative part Signed-off-by: Fiona Liao <[email protected]> * Whoops bad refactor Signed-off-by: Fiona Liao <[email protected]> * Add example yml Signed-off-by: Fiona Liao <[email protected]> * Feature flag instead and histogram hint handling Signed-off-by: Fiona Liao <[email protected]> * Delete otel_delta.yml - outdated Signed-off-by: Fiona Liao <[email protected]> * Renaming to native delta support Signed-off-by: Fiona Liao <[email protected]> * Add more explanatory comments Signed-off-by: Fiona Liao <[email protected]> * Add more explanation to histograms Signed-off-by: Fiona Liao <[email protected]> * Correct comment on d2c consumer Signed-off-by: Fiona Liao <[email protected]> * Add tests for counters and fix bug Signed-off-by: Fiona Liao <[email protected]> * Add histogram tests Signed-off-by: Fiona Liao <[email protected]> * Add docs Signed-off-by: Fiona Liao <[email protected]> * Sort series to make test deterministic Signed-off-by: Fiona Liao <[email protected]> * More formatting Signed-off-by: Fiona Liao <[email protected]> * Change flag name to ingestion Signed-off-by: Fiona Liao <[email protected]> * Explain where rate calculation can go wrong Signed-off-by: Fiona Liao <[email protected]> * Add warning about duplicate timestamps Signed-off-by: Fiona Liao <[email protected]> * Update docs/feature_flags.md Co-authored-by: Arthur Silva Sens <[email protected]> Signed-off-by: Fiona Liao <[email protected]> * Fix tests Signed-off-by: Fiona Liao <[email protected]> * Remove unnecessary if Signed-off-by: Fiona Liao <[email protected]> * Add warning to d2c section Signed-off-by: Fiona Liao <[email protected]> * Make unknown type error when getting temporality Signed-off-by: Fiona Liao <[email protected]> * Correct type comment - not planning to add delta metric metadata type Signed-off-by: Fiona Liao <[email protected]> * Remove unused param for empty type Signed-off-by: Fiona Liao <[email protected]> * Rewrite temporality logic to be clearer Signed-off-by: Fiona Liao <[email protected]> * Change spurious to unnecessary - better description Signed-off-by: Fiona Liao <[email protected]> --------- Signed-off-by: Fiona Liao <[email protected]> Co-authored-by: Arthur Silva Sens <[email protected]> * Add documentation for 'NoTranslation' mode (#16470) * Add documentation for 'NoTranslation' mode Signed-off-by: Arthur Silva Sens <[email protected]> * Update docs/configuration/configuration.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Arthur Silva Sens <[email protected]> --------- Signed-off-by: Arthur Silva Sens <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]> * fix conversion from time range in seconds to time duration at parser Signed-off-by: Zhang Zhanpeng <[email protected]> * promql: histogram_stddev and histogram_stdvar should use arithmetic mean for custom buckets Signed-off-by: amanycodes <[email protected]> * stable and definitely unique card UI key in /alerts Signed-off-by: amanycodes <[email protected]> * fix-ci-errors Signed-off-by: amanycodes <[email protected]> * stable and unique key for /rules page and key fixes Signed-off-by: amanycodes <[email protected]> * removed comments Signed-off-by: amanycodes <[email protected]> * Fix PRW2 data diff error message typo (#16481) Signed-off-by: SungJin1212 <[email protected]> * fix typo (#16480) Signed-off-by: Yuchen Wang <[email protected]> * Strip newline in error when reading from remote client (#16487) Signed-off-by: Jeanette Tan <[email protected]> * chore(deps): bump golang.org/x/net Bumps [golang.org/x/net](https://github.com/golang/net) from 0.37.0 to 0.38.0. - [Commits](https://github.com/golang/net/compare/v0.37.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/aws/aws-sdk-go from 1.55.6 to 1.55.7 Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.55.6 to 1.55.7. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG_PENDING.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.55.6...v1.55.7) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-version: 1.55.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/docker/docker Bumps [github.com/docker/docker](https://github.com/docker/docker) from 28.0.4+incompatible to 28.1.1+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](https://github.com/docker/docker/compare/v28.0.4...v28.1.1) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-version: 28.1.1+incompatible dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/Azure/azure-sdk-for-go/sdk/azidentity Bumps [github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://github.com/Azure/azure-sdk-for-go) from 1.8.2 to 1.9.0. - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](https://github.com/Azure/azure-sdk-for-go/compare/sdk/azidentity/v1.8.2...sdk/azcore/v1.9.0) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azidentity dependency-version: 1.9.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/prometheus/client_model from 0.6.1 to 0.6.2 Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.6.1 to 0.6.2. - [Release notes](https://github.com/prometheus/client_model/releases) - [Commits](https://github.com/prometheus/client_model/compare/v0.6.1...v0.6.2) --- updated-dependencies: - dependency-name: github.com/prometheus/client_model dependency-version: 0.6.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump google.golang.org/api from 0.229.0 to 0.230.0 Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.229.0 to 0.230.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.229.0...v0.230.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.230.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/gophercloud/gophercloud/v2 Bumps [github.com/gophercloud/gophercloud/v2](https://github.com/gophercloud/gophercloud) from 2.6.0 to 2.7.0. - [Release notes](https://github.com/gophercloud/gophercloud/releases) - [Changelog](https://github.com/gophercloud/gophercloud/blob/v2.7.0/CHANGELOG.md) - [Commits](https://github.com/gophercloud/gophercloud/compare/v2.6.0...v2.7.0) --- updated-dependencies: - dependency-name: github.com/gophercloud/gophercloud/v2 dependency-version: 2.7.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump google.golang.org/grpc from 1.71.1 to 1.72.0 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.71.1 to 1.72.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.71.1...v1.72.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.72.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/linode/linodego from 1.48.1 to 1.49.0 Bumps [github.com/linode/linodego](https://github.com/linode/linodego) from 1.48.1 to 1.49.0. - [Release notes](https://github.com/linode/linodego/releases) - [Commits](https://github.com/linode/linodego/compare/v1.48.1...v1.49.0) --- updated-dependencies: - dependency-name: github.com/linode/linodego dependency-version: 1.49.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/miekg/dns from 1.1.64 to 1.1.65 Bumps [github.com/miekg/dns](https://github.com/miekg/dns) from 1.1.64 to 1.1.65. - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](https://github.com/miekg/dns/compare/v1.1.64...v1.1.65) --- updated-dependencies: - dependency-name: github.com/miekg/dns dependency-version: 1.1.65 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/prometheus/client_golang Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.21.1 to 1.22.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.21.1...v1.22.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-version: 1.22.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/digitalocean/godo from 1.142.0 to 1.144.0 Bumps [github.com/digitalocean/godo](https://github.com/digitalocean/godo) from 1.142.0 to 1.144.0. - [Release notes](https://github.com/digitalocean/godo/releases) - [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md) - [Commits](https://github.com/digitalocean/godo/compare/v1.142.0...v1.144.0) --- updated-dependencies: - dependency-name: github.com/digitalocean/godo dependency-version: 1.144.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/prometheus/client_golang Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.21.1 to 1.22.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.21.1...v1.22.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-version: 1.22.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * [BUILD] Remove Go toolchain line in internal/tools (#16516) * Upgraded npm dependencies pre 3.4.0-rc.0 (#16493) * Volunteer Bryan Boreham as Shepherd for Release 3.5 Signed-off-by: Bryan Boreham <[email protected]> * Add `label_selector` to hetzner service discovery Allows to filter the servers when sending the listing request to the API. This feature is only available when using the `role=hcloud`. See https://docs.hetzner.cloud/#label-selector for details on how to use the label selector. Signed-off-by: Jonas Lammler <[email protected]> * Clarify the docs of promtool --{min,max}-time options State explicitely what kind of timestamps are expected for the --min-time and --max-time options of promtool tsdb commands. This is especially important for the dump-openmetrics command as users could otherwise mistakenly think it would be in seconds, like the OpenMetrics timestamps themselves. Signed-off-by: Nicolas Peugnet <[email protected]> * Labels: simpler/faster stringlabels encoding (#16069) Instead of using varint to encode the size of each label, use a single byte for size 0-254, or a flag value of 255 followed by the size in 3 bytes little-endian. This reduces the amount of code, and also the number of branches in commonly-executed code, so it runs faster. The maximum allowed label name or value length is now 2^24 or 16MB. Memory used by labels changes as follows: * Labels from 0 to 127 bytes length: same * From 128 to 254: 1 byte less * From 255 to 16383: 2 bytes more * From 16384 to 2MB: 1 byte more * From 2MB to 16MB: same Labels: panic on string too long. Slightly more user-friendly than encoding bad data and finding out when we decode. Clarify that Labels.Bytes() encoding can change --------- Signed-off-by: Bryan Boreham <[email protected]> * [BUGFIX] Top-level: Update GOGC before loading TSDB (#16491) We should use the configured value, or Prometheus' default of 75%, while initializing and loading the WAL. Since the Go default is 100%, most Prometheus users would experience higher memory usage before the value is configured. Also: move Go runtime params earlier in initialization. E.g. if a module starting up looks at GOMAXPROCS to size something, we need to have set it already. --------- Signed-off-by: Bryan Boreham <[email protected]> * promtool: Optional fuzzy float64 comparison in rules unittests (#16395) Make fuzzy compare opt-in via fuzzy_compare boolean in each unittest file. Signed-off-by: Graham Reed <[email protected]> * chore(deps): bump github/codeql-action from 3.28.13 to 3.28.16 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.13 to 3.28.16. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/1b549b9259bda1cb5ddde3b41741a82a2d15a841...28deaeda66b76a05916b6923827895f2b14ab387) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.28.16 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/ionos-cloud/sdk-go/v6 from 6.3.3 to 6.3.4 Bumps [github.com/ionos-cloud/sdk-go/v6](https://github.com/ionos-cloud/sdk-go) from 6.3.3 to 6.3.4. - [Release notes](https://github.com/ionos-cloud/sdk-go/releases) - [Changelog](https://github.com/ionos-cloud/sdk-go/blob/master/docs/CHANGELOG.md) - [Commits](https://github.com/ionos-cloud/sdk-go/compare/v6.3.3...v6.3.4) --- updated-dependencies: - dependency-name: github.com/ionos-cloud/sdk-go/v6 dependency-version: 6.3.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump the go-opentelemetry-io group across 2 directories with 5 updates Bumps the go-opentelemetry-io group with 4 updates in the / directory: [go.opentelemetry.io/collector/component](https://github.com/open-telemetry/opentelemetry-collector), [go.opentelemetry.io/collector/consumer](https://github.com/open-telemetry/opentelemetry-collector), [go.opentelemetry.io/collector/processor](https://github.com/open-telemetry/opentelemetry-collector) and [go.opentelemetry.io/collector/semconv](https://github.com/open-telemetry/opentelemetry-collector). Bumps the go-opentelemetry-io group with 2 updates in the /documentation/examples/remote_storage directory: [go.opentelemetry.io/collector/pdata](https://github.com/open-telemetry/opentelemetry-collector) and [go.opentelemetry.io/collector/semconv](https://github.com/open-telemetry/opentelemetry-collector). Updates `go.opentelemetry.io/collector/component` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/consumer` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/pdata` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/processor` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/semconv` from 0.124.0 to 0.125.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.124.0...v0.125.0) Updates `go.opentelemetry.io/collector/pdata` from 1.30.0 to 1.31.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.30.0...pdata/v1.31.0) Updates `go.opentelemetry.io/collector/semconv` from 0.124.0 to 0.125.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.124.0...v0.125.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/collector/component dependency-version: 1.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/consumer dependency-version: 1.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/pdata dependency-version: 1.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/processor dependency-version: 1.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/semconv dependency-version: 0.125.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/pdata dependency-version: 1.31.0 dependency-type: indirect update-type: version-update:semver-minor dependency-group: go-opentelemetry-io - dependency-name: go.opentelemetry.io/collector/semconv dependency-version: 0.125.0 dependency-type: indirect update-type: version-update:semver-minor dependency-group: go-opentelemetry-io ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump github.com/digitalocean/godo from 1.144.0 to 1.145.0 Bumps [github.com/digitalocean/godo](https://github.com/digitalocean/godo) from 1.144.0 to 1.145.0. - [Release notes](https://github.com/digitalocean/godo/releases) - [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md) - [Commits](https://github.com/digitalocean/godo/compare/v1.144.0...v1.145.0) --- updated-dependencies: - dependency-name: github.com/digitalocean/godo dependency-version: 1.145.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump google.golang.org/api from 0.230.0 to 0.231.0 Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.230.0 to 0.231.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.230.0...v0.231.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.231.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(cmd): Add info log for automemlimit config Signed-off-by: machine424 <[email protected]> * Prepare release 3.4.0-rc.0 (#16517) Co-authored-by: Ayoub Mrini <[email protected]> * Fix linting issues found by golangci-lint v2.0.2 (#16368) * Fix linting issues found by golangci-lint v2.0.2 --------- Signed-off-by: Arve Knudsen <[email protected]> * chore(deps): bump github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor Bumps [github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor](https://github.com/open-telemetry/opentelemetry-collector-contrib) from 0.124.1 to 0.125.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CHANGELOG-API.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector-contrib/compare/v0.124.1...v0.125.0) --- updated-dependencies: - dependency-name: github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor dependency-version: 0.125.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump golangci-lint to v2.1.5 (#16545) Signed-off-by: Matthieu MOREL <[email protected]> * chore(deps): bump actions/setup-node from 4.3.0 to 4.4.0 (#16533) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/cdca7365b2dadb8aad0a33bc7601856ffabcc48e...49933ea5288caeca8642d1e84afbd3f7d6820020) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * promql: don't emit a value from `histogram_fraction` or `histogram_quantile` if classic and native histograms are present at the same timestamp Signed-off-by: Charles Korn <[email protected]> * Add global config option for always_scrape_classic_histograms Addresses https://github.com/prometheus/prometheus/issues/16371 This will help with migrating to native histograms with `convert_classic_histograms_to_nhcb` since users may still need to keep the classic histograms during a migration Signed-off-by: chardch <[email protected]> * fix promql-test error message and readme Signed-off-by: Neeraj Gartia <[email protected]> * chore(scripts/sync_repo_files): add link to source script Signed-off-by: machine424 <[email protected]> * tsdb/errors.MultiError: support errors.As (#16544) * tsdb/errors.MultiError: implement Unwrap the multierror was hiding some errors in Mimir. I also added unit tests because I had them handy from a similar change I and yuri did in XXX and some time ago --------- Signed-off-by: Dimitar Dimitrov <[email protected]> Co-authored-by: Arve Knudsen <[email protected]> * test(cmd): add test for GOGC setting As suggested in https://github.com/prometheus/prometheus/pull/14176#issuecomment-2150308054 Signed-off-by: machine424 <[email protected]> * [PERF] TSDB: Pass down label value limit into implementation (#16158) * allow limiting label values calls Signed-off-by: Andre Branchizio <[email protected]> * update fix configuration.md Signed-off-by: dongjiang <[email protected]> * Add a test for aggregation wrapped in ParenExpr Signed-off-by: Lukasz Mierzwa <[email protected]> * fix(parser): parenthesis around aggregate expression parsing The position range of nested aggregate expression was wrong, for the expression "(sum(foo))" the position of "sum(foo)" should be 1-9, but the parser could not decide the end of the expression on pos 9, instead it read ahead to pos 10 and then emitted the aggregate. But we only kept the last closing position (10) and wrote that into the aggregate. The reason for this is that the parser cannot know from "(sum(foo)" alone if the aggregate is finished. It could be finished as in "(sum(foo))" but equally it could continue with group modifier as "(sum(foo) by (bar))". The fix is to track ")" tokens in a stack in addition to the lastClosing position, which is overloaded with other things like offset number tracking. Signed-off-by: György Krajcsovits <[email protected]> * Fix position in TestPreprocessAndWrapWithStepInvariantExpr This is failing after 26088d01b9518b3315805186dcee534b986bf79f and it seems that currently tested position is incorrect, fix it Signed-off-by: Lukasz Mierzwa <[email protected]> * docs: Fix `metric_name_escaping_scheme` config parameter This is a fix for documentation update done in https://github.com/prometheus/prometheus/pull/16066, setting correct name for a configuration value. Signed-off-by: Martin Danko <[email protected]> * chore(engine): add simple NHCB benchmark Copy the benchmark for native histograms with exponential buckets and adopt to native histograms with custom buckets. Signed-off-by: György Krajcsovits <[email protected]> * perf(chunkenc): intern the custom values for native histograms The custom values are the "le" bucket boundaries of native histograms with custom buckets. They are never modified. It is ok to not copy them when iterating a chunk, just reference them. If we will ever have a function that modifies the custom values, like 'trim' for example. That function will have to make a copy on write. Signed-off-by: György Krajcsovits <[email protected]> * UI: optimize pool searching in /target page Signed-off-by: Ryan Wu <[email protected]> * refactor: use slices.Contains to simplify code Signed-off-by: hardlydearly <[email protected]> * promql: Refactor some functions to make them more DRY (#16532) Signed-off-by: Neeraj Gartia <[email protected]> * promql: support variable scalar parameter in aggregations in range queries (#16404) This fixes the regression introduced in https://github.com/prometheus/prometheus/issues/15971 while preserving the performance improvements. Signed-off-by: Neeraj Gartia <[email protected]> * Try fixing potential deadlocks in discovery Manager.ApplyConfig() uses multiple locks: - Provider.mu - Manager.targetsMtx Manager.cleaner() uses the same locks but in the opposite order: - First it locks Manager.targetsMtx - The it locks Provider.mu I've seen a few strange cases of Prometheus hanging up on shutdown and never compliting that shutdown. From a few traces I was given it appears that while Prometheus is still running only discovery.Manager and notifier.Manager are running running. From that trace it also seems like they are stuck on a lock from two functions: - cleaner waits on a RLock() - ApplyConfig waits on a Lock() I cannot reproduce it but I suspect this is a race between locks. Imagine this scenario: - Manager.ApplyConfig() is called - Manager.ApplyConfig locks Provider.mu.Lock() - at the same time cleaner() is called on the same Provider instance and it calls Manager.targetsMtx.Lock() - Manager.ApplyConfig() now calls Manager.targetsMtx.Lock() but that lock is already held by cleaner() function so ApplyConfig() hangs there - at the same time cleaner() now wants to lock Provider.mu.Rlock() but that lock is already held by Manager.ApplyConfig() - we end up with both functions locking each other out without any way to break that lock Re-order lock calls to try to avoid this scenario. I tried writing a test case for it but couldn't hit this issue. Signed-off-by: Lukasz Mierzwa <[email protected]> * Optimize memoization and search debouncing on /targets page (#16589) Moving the debouncing of the search field to the parent component and then memoizing the ScrapePoolsList component prevents a lot of superfluous re-renders of the entire scrape pools list that previously got triggered immediately when you typed in the search box or even just collapsed a pool. (While the computation of what data to show was already memoized in the ScrapePoolList component, the component itself still had to re-render a lot with the same data.) Discovered this problem + verified fix using react-scan. Signed-off-by: Julius Volz <[email protected]> * Fix full-page re-rendering when opening status nav menu (#16590) When opening the status pages menu while already viewing one of the status pages, the whole page would be re-rendered because the menu target's default action of following the current page's URL was not prevented. Also, we don't need to use a NavLink component for the menu target when we are not viewing a status page, because then the component won't need to be highlighted anyways. Discovered + fixed with the help of react-scan. Signed-off-by: Julius Volz <[email protected]> * fix(config): respect GOGC environment variable if no "runtime" block exists Fixes: https://github.com/prometheus/prometheus/issues/16334 Related to: - https://github.com/prometheus/prometheus/pull/15238 - https://github.com/prometheus/prometheus/pull/16052 Currently, when the GOGC environment variable is set -- and no `runtime` block is set in the Prometheus config file -- it is ignored and the default value of 75% is always used. However, if there is an empty runtime block (e.g. `runtime: {}`), _then_ the GOGC environment variable is checked. This PR changes this behavior to consistently check and use the GOGC environment variable when it is set (unless the `gogc` field is set in the `runtime` block of the loaded config file, in which case it still gives that precedence). Co-authored-by: Adam Rambo <[email protected]> Signed-off-by: Will Hegedus <[email protected]> * test(cmd): enable test cases for GOGC environment variable Signed-off-by: Will Hegedus <[email protected]> * Clean up codeboxes and headings in docs The new docs site will have syntax highlighting, so this adds language tags to code boxes that are currently missing them. I didn't add `promql` as a language yet since the highlighter doesn't support it yet, plus a lot of the PromQL codeboxes in our docs aren't strictly valid PromQL, they are more like multiple expressions listed in the same code box on multiple lines. So I'm leaving that for sometime later. In the HTTP API page, I moved the curl examples from the JSON codeboxes to their own ones above the JSON output. I considered putting an "Output:" text between the curl + JSON output, but I think the way it currently looks without it is probably fine. I also fixed a number of headings which were at the wrong level relative to their nesting in the document. I also removed `go` as a language from the Go template language examples, because the Go template language isn't Go at all. I also adjusted the indent on one codebox to be more reasonable (2 spaces instead of 8). And then finally, my editor made a bunch of whitespace changes automatically, like removing trailing spaces. Signed-off-by: Julius Volz <[email protected]> Signed-off-by: Julius Volz <[email protected]> * Move m.targetsMtx.Lock down into the loop Make sure the order of locks is always the same in all functions. In ApplyConfig() we have m.targetsMtx.Lock() after provider is locked, so replicate the same in allGroups(). Signed-off-by: Lukasz Mierzwa <[email protected]> * Fixup make proto (#16603) Use `common-` prefix for `make proto` so downstream projects like client_golang can implement their own `make proto`. Signed-off-by: SuperQ <[email protected]> * Add golangci-lint fmt (#16602) With golangci-lint v2, it now has "formatters" that can be configured. Add `golangci-lint fmt` to the `make format` in Makefile.common. * Enable goimports formatter. Signed-off-by: SuperQ <[email protected]> * SD UI: Better total target count display when using `keep_dropped_targets` option Fixes https://github.com/prometheus/prometheus/issues/16586 Signed-off-by: Julius Volz <[email protected]> * Add health & text filtering on the /rules page Addresses part of https://github.com/prometheus/prometheus/issues/16515 For now, I'm adding very similar filtering to the /rules page as we have on the /alerts page, with the difference being: * The state filter filters by rule health (ok/warn/unknown) instead of alert state (firing/pending/inactive) * We don't collect & show detailed stats on the different state counts as we do on the /alerts page There is a lot of copied / very similar code between those two pages (and also some others) around filtering and pagination, so maybe there is an opportunity for more code sharing in the future here. Signed-off-by: Julius Volz <[email protected]> * docs: fix typo in operators.md Signed-off-by: marcoderama <[email protected]> * Release 3.4.0 (#16600) * Adjust release date in CHANGELOG.md Signed-off-by: Jan-Otto Kröpke <[email protected]> * Merge release-3.4 into main (#16609) Co-authored-by: Ayoub Mrini <[email protected]> * Fix flakiness in TestOTLPWriteHandler (#16608) * feature: type-and-unit-labels (PROM-39 implementation) (#16228) * feature: type-and-unit-labels (extended MetricIdentity) Experimental implementation of https://github.com/prometheus/proposals/pull/39 Previous (unmerged) experiments: * https://github.com/prometheus/prometheus/compare/main...dashpole:prometheus:type_and_unit_labels * https://github.com/prometheus/prometheus/pull/16025 Signed-off-by: bwplotka <[email protected]> feature: type-and-unit-labels (extended MetricIdentity) Experimental implementation of https://github.com/prometheus/proposals/pull/39 Previous (unmerged) experiments: * https://github.com/prometheus/prometheus/compare/main...dashpole:prometheus:type_and_unit_labels * https://github.com/prometheus/prometheus/pull/16025 Signed-off-by: bwplotka <[email protected]> * Fix compilation errors Signed-off-by: Arthur Silva Sens <[email protected]> Lint Signed-off-by: Arthur Silva Sens <[email protected]> Revert change made to protobuf 'Accept' header Signed-off-by: Arthur Silva Sens <[email protected]> Fix compilation errors for 'dedupelabels' tag Signed-off-by: Arthur Silva Sens <[email protected]> * Rectored into schema.Metadata Signed-off-by: bwplotka <[email protected]> * texparse: Added tests for PromParse Signed-off-by: bwplotka <[email protected]> * add OM tests. Signed-off-by: bwplotka <[email protected]> * add proto tests Signed-off-by: bwplotka <[email protected]> * Addressed comments. Signed-off-by: bwplotka <[email protected]> * add schema label tests. Signed-off-by: bwplotka <[email protected]> * addressed comments. Signed-off-by: bwplotka <[email protected]> * fix tests. Signed-off-by: bwplotka <[email protected]> * add promql tests. Signed-off-by: bwplotka <[email protected]> * lint Signed-off-by: bwplotka <[email protected]> * Addressed comments. Signed-off-by: bwplotka <[email protected]> --------- Signed-off-by: bwplotka <[email protected]> Signed-off-by: Arthur Silva Sens <[email protected]> Co-authored-by: Arthur Silva Sens <[email protected]> * util/httputil: Always add Vary header in SetCORS Closes #15406 Signed-off-by: jub0bs <[email protected]> * refactor: use the built-in max/min to simplify the code Signed-off-by: carrychair <[email protected]> * refactor(endpointslice): use service cache.Indexer to achieve better iteration performance (#16365) * refactor(endpointslice): use cache.Indexer to index endpointslices by LabelServiceName so not have to iterate over all endpoint objects. Signed-off-by: Ryan Wu <[email protected]> * check the type and error early and add 'TestEndpointSliceDiscoveryWithUnrelatedServiceUpdate' unit test to give a regression test Signed-off-by: Ryan Wu <[email protected]> * make service indexer namespaced Signed-off-by: Ryan Wu <[email protected]> * remove unneeded test func Signed-off-by: Ryan Wu <[email protected]> * Apply suggestions from code review Co-authored-by: Ayoub Mrini <[email protected]> Signed-off-by: Ryan Wu <[email protected]> --------- Signed-off-by: Ryan Wu <[email protected]> Co-authored-by: Ayoub Mrini <[email protected]> * feat(tsdb): introduce --use-uncached-io feature flag and allow using it for chunks writing (#15365) Signed-off-by: machine424 <[email protected]> Signed-off-by: Ayoub Mrini <[email protected]> * test(cmd/main/TestRuntimeGOGCConfig): add checks on reloads as well Signed-off-by: machine424 <[email protected]> * chore(config): add guidelines for adding a new RuntimeConfig field based on learnings from GoGC addition Signed-off-by: machine424 <[email protected]> * fix: add reproducer for a dangling-reference issue in parsers Signed-off-by: machine424 <[email protected]> * fix(model/textparse): Labels(): copy the input to avoid dangling references Signed-off-by: machine424 <[email protected]> * fix metric_name_escaping_scheme option (#16625) * remote_write azure auth : allow empty client_id to suppport system assigned managed identity (#16421) * squash (#1) * remote-write: allow empty azure client_id to support system assigned managed identity * add blank line for tests * remote-write: allow empty azure client_id to support system assigned managed identity Signed-off-by: Kaveesh Dubey <[email protected]> * add blank line for tests Signed-off-by: Kaveesh Dubey <[email protected]> --------- Signed-off-by: Kaveesh Dubey <[email protected]> * treat empty client_id as system-assigned identity; this is a valid case Signed-off-by: Kaveesh Dubey <[email protected]> * rename file Signed-off-by: bragi92 <[email protected]> --------- Signed-off-by: Kaveesh Dubey <[email protected]> Signed-off-by: bragi92 <[email protected]> * ci: address zizmor gh action vulnerabilities (#16530) * ci: address zizmor gh action vulnerabilities --------- Signed-off-by: Joe Harvey <[email protected]> Signed-off-by: Arve Knudsen <[email protected]> Co-authored-by: Arve Knudsen <[email protected]> Co-authored-by: Copilot <[email protected]> * Add support for promoting all OTel resource attributes (#16426) Add support for promoting all OTel resource attributes via `promote_all_resource_attributes`, except for those ignored using 'ignore_resource_attributes'. --------- Signed-off-by: Antonio Jimenez <[email protected]> Signed-off-by: Antonio Jimenez <[email protected]> * Add parse alerting for rules files (#16601) Builds over https://github.com/prometheus/prometheus/pull/16462 Addresses comments, adds invalid rules file Signed-off-by: subhramit <[email protected]> Co-authored-by: marcodebba <[email protected]> * chore: Adjust test and add comment about DNS resolution issue for failing tests (#16200) * chore: Add comment about DNS resolution issue for failing tests Signed-off-by: zhengkezhou1 <[email protected]> * remove unexported-return Signed-off-by: zhengkezhou1 <[email protected]> --------- Signed-off-by: zhengkezhou1 <[email protected]> * [BACKPORT-3.4] fix: add reproducer for a dangling-reference issue in parsers and fix (#16633) * chore: fix some comments Signed-off-by: tongjicoder <[email protected]> * refactor: Move 'for' state restoration metrics to defer block Signed-off-by: Anand Rajagopal <[email protected]> * tsdb: fix issue where a new segment file is created for every chunk if `WithSegmentSize` not called (#16635) * tsdb: fix issue where a new segment file is created for every chunk Signed-off-by: Charles Korn <[email protected]> * Address PR feedback Signed-off-by: Charles Korn <[email protected]> --------- Signed-off-by: Charles Korn <[email protected]> * Standardize doc page title handling See https://groups.google.com/g/prometheus-developers/c/cwL3cM66Em8 Signed-off-by: Julius Volz <[email protected]> * fix(test): fall back to default direct I/O requirements in tests when statx isn't supported by using a higher lever util Signed-off-by: machine424 <[email protected]> * Update otlptranslator with new API (#16626) * Update otlptranslator with new API Signed-off-by: Arthur Silva Sens <[email protected]> --------- Signed-off-by: Arthur Silva Sens <[email protected]> * Release 3.4.1 (#16652) * test(promql): histogram_count inconsistent Ref: https://github.com/prometheus/prometheus/issues/16681 Signed-off-by: György Krajcsovits <[email protected]> * fix(promql): histogram_count inconsistent The problem is in the counter reset detection. The code that loads the samples is matrixIterSlice which uses the typed Buffer iterator, which will preload the integer histogram samples, however the last sample is always(!) loaded as a float histogram sample in matrixIterSlice and the optimized iterator fails to detect counter resets in that case. Also the iterator does not reset lastH, lastFH properly. Ref: https://github.com/prometheus/prometheus/issues/16681 Signed-off-by: György Krajcsovits <[email protected]> * Make translatorMetricFromOtelMetric public (#16683) Signed-off-by: Jeanette Tan <[email protected]> * fix(promql): do not loose information about buckets when doing the detect Signed-off-by: György Krajcsovits <[email protected]> * bugfix: Default OTLP config not respected when `otlp:` block is unset (#16693) Co-authored-by: Jan-Otto Kröpke <[email protected]> * promqltest: Adjust more tests to "left-open" ranges This was an oversight because the old tests still happened to pass with the new behavior, but important test data was excluded at the left end of the interval, rendering some tests not actually testing what we want to test. In the past, we also applied different strategies to adjust the test (extend the range from 1m to 2m, or set the evaluation timestamp to 45s). This commit unifies things and reduces redundancy. Signed-off-by: beorn7 <[email protected]> * promql: Simplify avg aggregation and avg_over_time As it turns out, if we combine Kahan summation and incremental mean calculation properly, it works quite well and we do not need to switch between simple mean calculation and incremental calculation based on overflow. This simplifies the code quite a bit. Signed-off-by: beorn7 <[email protected]> * Export QuerySamples StartTimestamp and Interval to enable custom statistics implementations to populate these fields as needed. Signed-off-by: Innokentii Konstantinov <[email protected]> * chore(docs/kubernetes SD): add a note about Endpoints API being deprecated in kubernetes 1.33+ (#16684) * chore(docs/kubernetes SD): add a note about Endpoints API being deprecated in kubernetes 1.33+ Signed-off-by: machine424 <[email protected]> * chore(discovery/kubernetes): add Endpoints API deprecation comment Signed-off-by: machine424 <[email protected]> --------- Signed-off-by: machine424 <[email protected]> * PROM-39: Provide PromQL info annotations when rate()/increase() over series without `__type__`="counter" label (#16632) * Provide PromQL info annotations when rate()/increase() over series without counter label Signed-off-by: Arthur Silva Sens <[email protected]> * Address comments Signed-off-by: Arthur Silva Sens <[email protected]> --------- Signed-off-by: Arthur Silva Sens <[email protected]> * [Refactor] PromQL: Simplify detectHistogramStatsDecoding Restarting the depth-first walk on each leg of a binary expression is convoluted. ISTM the correct logic is to walk the path backwards to the first relevant function. Signed-off-by: Bryan Boreham <[email protected]> * Add more avg_over_time test cases with extreme values These tests were initially created by @crush-on-anechka. I modified them slightly. Signed-off-by: beorn7 <[email protected]> * Enhancement: Reload all scrape pools concurrently (#16595) * Reload all scrape pools concurrently At the moment all scrape pools that need to be reloaded are reloaded one by one. While reloads are ongoing mtxScrape is locked. For each pool that's being reloaded we need to wait until all targets are updated. This whole process can take a while and the more scrape pools to reload the longer. At the same time all pools are independent and there's no real reason to do them one-by-one. Reload each pool in a seperate goroutine so we finish config reload as ASAP as possible and unlock the mtxScrape. Signed-off-by: Lukasz Mierzwa <[email protected]> * Address PR review feedback Signed-off-by: Lukasz Mierzwa <[email protected]> --------- Signed-off-by: Lukasz Mierzwa <[email protected]> * promql: Deactivate three failing tests for the time being These tests fail on darwin/arm64. One is expected, because the test demonstrates the limits of the numerical accuracy of our methods, and different inaccurate outcomes on different hardware are expected. The other two are mysterious at the moment, see https://github.com/prometheus/prometheus/issues/16714 for detailed discussion and debugging. Signed-off-by: beorn7 <[email protected]> * promql: typo fix in comment Signed-off-by: beorn7 <[email protected]> * engine: fix PossibleNonCounterInfo annotation for rate and increase. (#16718) * Comment exposed field Signed-off-by: Innokentii Konstantinov <[email protected]> * Remove invalid test Signed-off-by: Innokentii Konstantinov <[email protected]> * Fix PossibleNonCounterInfo annotation. Signed-off-by: Innokentii Konstantinov <[email protected]> * lint Signed-off-by: Innokentii Konstantinov <[email protected]> --------- Signed-off-by: Innokentii Konstantinov <[email protected]> * fix(nhcb): do not loose NHCB after exponential with different labels The problem happens when we parse a standalone native histogram, which sets the p.lastHistogramExponential state flag. We never unset it. Signed-off-by: György Krajcsovits <[email protected]> * refactor(nhcb): get rid of extra lastHistogramExponential state and make it a regular state of inhibiting NHCB conversion. Signed-off-by: György Krajcsovits <[email protected]> * Enhance TestDropOldTimeSeries to test both v1 and v2 protocols (#16709) - Wrapped existing test logic in a loop to run with both protocol versions - Ensures consistent behavior across protocol versions for dropping old time series Signed-off-by: AxcelXander <[email protected]> Co-authored-by: AxcelXander <[email protected]> * mantine-ui: fix /alerts accordian theme colors (#16043) * fix-alerts-accordion-theme Signed-off-by: amanycodes <[email protected]> * fixes Signed-off-by: amanycodes <[email protected]> * added changes to /rules page Signed-off-by: amanycodes <[email protected]> * more fixes Signed-off-by: amanycodes <[email protected]> --------- Signed-off-by: amanycodes <[email protected]> Signed-off-by: Aman <[email protected]> * Fetch and display full query stats in hover tooltip in table query tab (#16723) Fixes https://github.com/prometheus/prometheus/issues/5857 Signed-off-by: Julius Volz <[email protected]> * promql: add ts_of_(max,min,last)_over_time functions This commit adds the ts_of_(max,min,last)_over_time functions behind the experimental feature flag. Signed-off-by: Michael Hoffmann <[email protected]> * promql: Fix unary operator precedence in duration expressions Split unary operator handling in duration expressions into two specific cases to fix precedence conflicts: - Handle unary operators with number literals directly - Handle unary operators with parenthesized expressions separately This prevents unary minus from incorrectly binding to subsequent operators in expressions like `foo offset -1^1`, ensuring it parses as `(foo offset -1) ^ 1` rather than `foo offset (-1^1)`. Fixes #16711 Signed-off-by: Julien Pivotto <[email protected]> * Update duration expression docs Signed-off-by: Julien Pivotto <[email protected]> * promql: fix ts_of_last_over_time for histogram vectors This PR fixes a bug in ts_of_last_over_time where the float samples where used when computing the last timestamp of the histogram samples. Signed-off-by: Michael Hoffmann <[email protected]> * config: fix typo in comments (#16734) Signed-off-by: Owen Williams <[email protected]> * discovery: add STACKIT SD (#16401) * Fix unit for Scrape failures Signed-off-by: datamuc <[email protected]> * PromQL: Fix native histogram last_over_time with offset Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]> * OTLP: Support including scope metadata as metric labels (#16730) Signed-off-by: Arve Knudsen <[email protected]> * promql: reuse `histogramStatsIterator` where possible, and expose it for other implementations to use (#16686) * Expose type * Add `Reset` method --------- Signed-off-by: Charles Korn <[email protected]> * Add script for converting PromQL tests to new syntax format (#16562) Signed-off-by: Kapil Lamba <[email protected]> Co-authored-by: Neeraj Gartia <[email protected]> * mantine-ui: add query warnings display to graph view Signed-off-by: Julien Pivotto <[email protected]> * fix: prevent invalid array access in aggregate expression This commit fixes the evaluation of invalid expressions like `sum(rate(`. Before that, it would trigger a panic in the PromQL engine because it tried to access an index which is out of range. The bug was probably introduced by 06d0b063ea. Signed-off-by: Simon Pasquier <[email protected]> * mantine-ui: add query info warnings display to graph view Followup of https://github.com/prometheus/prometheus/pull/16753 Signed-off-by: Julien Pivotto <[email protected]> * OTLP receiver: Rename `otlp.convert_scope_metadata` to `otlp.promote_scope_metadata` (#16760) * Rename otlp.convert_scope_metadata to otlp.promote_scope_metadata --------- Signed-off-by: Arve Knudsen <[email protected]> Co-authored-by: Julius Hinze <[email protected]> * [BUILD] Ran make update-go-deps Signed-off-by: Bryan Boreham <[email protected]> * [BUILD] Wind back otlptranslator update which has breaking change Signed-off-by: Bryan Boreham <[email protected]> * [BUILD] Wind back dependencies which require Go 1.24 We need Prometheus to build with the last 2 versions of Go. Remove Go toolchain line - it is redundant with the `go`` line above, and could mislead readers. Also don't update `fsnotify` which is pinned to an older version. Signed-off-by: Bryan Boreham <[email protected]> * [TESTS] Rules: remove brittle TestNewGroup It broke on different implementation of 'NewNopLogger'. Signed-off-by: Bryan Boreham <[email protected]> * [BUILD] Docker SD: Fix up deprecated types Signed-off-by: Bryan Boreham <[email protected]> * Add tests for relabeling of type and unit labels (#16743) Signed-off-by: Carrie Edwards <[email protected]> * Add documentation for custom_values usage in NHCB (#16757) Signed-off-by: rishi-jat <[email protected]> Signed-off-by: Rishi Jat <[email protected]> Co-authored-by: George Krajcsovits <[email protected]> * fix(promql): histogram_quantile and histogram_fraction NaN observed in native histogram (#16724) * fix(promql): histogram_quantile NaN observed in native histogram Fixes: #16578 See the issue for detailed explanation. When a histogram had only NaN observations and no normal observations, we returned 0 from the quantile, which is completely wrong. If there were normal observations but we went over them, we returned the upper bound of the existing buckets, however that contradicts expectations on histogram_fraction. Now we return NaN if the quantile is calculated to be over all normal observations, falling into NaNs (in a virtual +Inf bucket). We also return info level annotations if we see any NaN observations. The annotation calls out if we returned NaN or even if we took the virtual +Inf bucket into account. Signed-off-by: György Krajcsovits <[email protected]> * fix(promql): histogram_fraction NaN observed in native histogram Fixes: #16580 According to the specification we should not take NaN observations into account when calculating the fraction. This commit fixes that and adds an info level annotation to let the user know about this. Signed-off-by: György Krajcsovits <[email protected]> * scrape: set validation and escaping defaults in default config vars (#16751) Fixes https://github.com/prometheus/prometheus/issues/16750 Signed-off-by: Owen Williams <[email protected]> * OTLP receiver: Don't append _total suffix to non-monotonic OTel sums (#16776) * OTLP receiver: Don't append _total suffix to non-monotonic OTel sums Fix the OTLP receiver so the suffix _total isn't appended to metrics converted from non-monotonic OTel sum metrics, if otlp.translation_strategy is UnderscoreEscapingWithSuffixes or NoUTF8EscapingWithSuffixes. Also add translation tests. --------- Signed-off-by: Arve Knudsen <[email protected]> * Prepare release 3.4.2 Signed-off-by: Jan-Otto Kröpke <[email protected]> * Limit concurrency of scrape pool reloads (#16783) To avoid possible overload. As per https://github.com/prometheus/prometheus/pull/16595#issuecomment-3005027067 this changes scrape pool manager to limit the number of scrape pools that can reload at the same time. Signed-off-by: Lukasz Mierzwa <[email protected]> * promql: Add test cases for direct mean calculation These demonstrate that direct mean calculation has some merits after all. Signed-off-by: beorn7 <[email protected]> * promql: Remove falsified comment from test The test in question actually worked fine even before #16569. The finding reported in the comment has turned out to be caused by something else. Signed-off-by: beorn7 <[email protected]> * promql: Re-introduce direct mean calculation for better accuracy This commit brings back direct mean calculation (for `avg` and `avg_over_time`) but isn't an outright revert of #16569. It keeps the improved incremental mean calculation and features generally a bit cleaner code than before. Also, this commit... - ...updates the lengthy comment explaining the whole situation and trade-offs. - ...divides the running sum and the Kahan compensation term separately (in direct mean calculation) to avoid the (unlikely) possibility that sum and Kahan compensation together ovorflow float64. - ...uncomments the tests that should now work again on darwin/arm64. - ...uncomments the test that should now reliably yield the (inaccurate) value 0 on all hardware platforms. Also, the test description has been updated accordingly. - ...adds avg_over_time tests for zero and one sample in the range. Signed-off-by: beorn7 <[email protected]> * Prepare release 3.5.0-rc.0 (#16778) Signed-off-by: Bryan Boreham <[email protected]> Co-authored-by: Julius Volz <[email protected]> * Revert: OTLP Support including scope metadata as metric labels (#16842) Reverts #16730 and #16760 This is being done because we've noticed a problem in the spec that could lead to name collisions if attributes name, version or schema_url are added to the scope. They would collide with the already reserved labels otel_scope_name, otel_scope_version and otel_scope_schema_url. Since this new configuration option never made it into a release, we can safely remove it from the 3.5 release. We'll sort this out for the 3.6 release Signed-off-by: Arthur Silva Sens <[email protected]> * Prepare release 3.5.0-rc.1 (#16845) This RC reverts the feature "OTLP: Support promoting OTel scope attributes". Add the line back into the CHANGELOG for 3.5.0-rc.0, since we are not changing that version. Signed-off-by: Bryan Boreham <[email protected]> * Prepare release 3.5.0 Signed-off-by: Bryan Boreham <[email protected]> * [bot] assets: generate Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [create-pull-request] automated change Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update base image version to rhel_9_1.24 * Update promu build command in Containerfile.operator * Update Dockerfile.prow * Modify build command to include static assets directory * Update Containerfile.operator * Update PREBUILT_ASSETS_STATIC_DIR in Dockerfile.prow * Update buf-lint.yml * Modify .gitignore for UI asset tracking Updated .gitignore to track specific UI assets and exclude others. * update assets Signed-off-by: Coleen Iona Quadros <[email protected]> * Update Dockerfile.prow * Refactor Containerfile by removing unused copies --------- Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: Neeraj Gartia <[email protected]> Signed-off-by: Arthur Silva Sens <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: machine424 <[email protected]> Signed-off-by: Fiona Liao <[email protected]> Signed-off-by: Zhang Zhanpeng <[email protected]> Signed-off-by: amanycodes <[email protected]> Signed-off-by: SungJin1212 <[email protected]> Signed-off-by: Yuchen Wang <[email protected]> Signed-off-by: Jeanette Tan <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Bryan Boreham <[email protected]> Signed-off-by: Jonas Lammler <[email protected]> Signed-off-by: Nicolas Peugnet <[email protected]> Signed-off-by: Graham Reed <[email protected]> Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Charles Korn <[email protected]> Signed-off-by: chardch <[email protected]> Signed-off-by: Dimitar Dimitrov <[email protected]> Signed-off-by: Andre Branchizio <[email protected]> Signed-off-by: dongjiang <[email protected]> Signed-off-by: Lukasz Mierzwa <[email protected]> Signed-off-by: György Krajcsovits <[email protected]> Signed-off-by: Martin Danko <[email protected]> Signed-off-by: Ryan Wu <[email protected]> Signed-off-by: hardlydearly <[email protected]> Signed-off-by: Julius Volz <[email protected]> Signed-off-by: Will Hegedus <[email protected]> Signed-off-by: SuperQ <[email protected]> Signed-off-by: marcoderama <[email protected]> Signed-off-by: bwplotka <[email protected]> Signed-off-by: jub0bs <[email protected]> Signed-off-by: carrychair <[email protected]> Signed-off-by: Ayoub Mrini <[email protected]> Signed-off-by: Kaveesh Dubey <[email protected]> Signed-off-by: bragi92 <[email protected]> Signed-off-by: Joe Harvey <[email protected]> Signed-off-by: Antonio Jimenez <[email protected]> Signed-off-by: Antonio Jimenez <[email protected]> Signed-off-by: subhramit <[email protected]> Signed-off-by: zhengkezhou1 <[email protected]> Signed-off-by: tongjicoder <[email protected]> Signed-off-by: Anand Rajagopal <[email protected]> Signed-off-by: beorn7 <[email protected]> Signed-off-by: Innokentii Konstantinov <[email protected]> Signed-off-by: AxcelXander <[email protected]> Signed-off-by: Aman <[email protected]> Signed-off-by: Julien Pivotto <[email protected]> Signed-off-by: Owen Williams <[email protected]> Signed-off-by: datamuc <[email protected]> Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]> Signed-off-by: Kapil Lamba <[email protected]> Signed-off-by: Simon Pasquier <[email protected]> Signed-off-by: Carrie Edwards <[email protected]> Signed-off-by: rishi-jat <[email protected]> Signed-off-by: Rishi Jat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jan-Otto Kröpke <[email protected]> Co-authored-by: Neeraj Gartia <[email protected]> Co-authored-by: Julien <[email protected]> Co-authored-by: George Krajcsovits <[email protected]> Co-authored-by: Björn Rabenstein <[email protected]> Co-authored-by: Bryan Boreham <[email protected]> Co-authored-by: Arthur Silva Sens <[email protected]> Co-authored-by: Michael Hoffmann <[email protected]> Co-authored-by: Björn Rabenstein <[email protected]> Co-authored-by: machine424 <[email protected]> Co-authored-by: Fiona Liao <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Zhang Zhanpeng <[email protected]> Co-authored-by: Aman <[email protected]> Co-authored-by: amanycodes <[email protected]> Co-authored-by: Julius Volz <[email protected]> Co-authored-by: SungJin1212 <[email protected]> Co-authored-by: Yuchen Wang <162491048+yuchen-db@…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of prometheus/proposals#39
Previous (unmerged) experiments:
TODO:
Not in this PR, but in the same feature flag we should: