promql: return NaN from irate() if second-last sample is NaN
#16199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Korn <[email protected]>
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 12, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 12, 2025
charleskorn
changed the title
irate() if either of last two samples is NaNirate() if second-last sample is NaN
|
CI linting failure seems completely unrelated to this change. |
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 12, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 12, 2025
* Upgrade mimir-prometheus * Bring in upstream test changes * Apply change to match prometheus/prometheus#15974 * Remove test case added in upstream in prometheus/prometheus#15975 * Add tests for case where range vector selectors and subqueries have 0 range Brings in change from #10586 * Update `sort` and `sort_desc` behaviour to match prometheus/prometheus#15964 * Add support for native histograms to `irate` and `idelta` to match prometheus/prometheus#15853 * Adjust test cases to match support for native histograms in `irate` and `idelta` * Change binop annotations to match behaviour in prometheus/prometheus#15895 * Ignore incompatible schemas between the first and second point in `rate` and `increase` if the second point is a reset (prometheus/prometheus#15902) * Adjust annotation test cases to match new behaviour introduced in previous commit * Disable tests failing due to prometheus/prometheus#16199 * Add changelog entry * Update `TestQuerySharding_FunctionCorrectness` to reflect changes in prometheus/prometheus#15964
Yes, see the ongoing issue #16203 |
beorn7
requested changes
Mar 12, 2025
Signed-off-by: Charles Korn <[email protected]>
beorn7
approved these changes
Mar 13, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
zenador
pushed a commit
to grafana/mimir
that referenced
this pull request
Mar 21, 2025
* Upgrade mimir-prometheus * Adjust tests to match new pretty printing format in prometheus/prometheus#16083 * Fix breaking change from prometheus/prometheus#16156 * Upgrade to github.com/oklog/ulid/v2 (prometheus/prometheus#16168) * Bring in changes from prometheus/prometheus#16199 * Remove OOO native histograms flag (prometheus/prometheus#16207) * Add changelog entries * Ignore deprecation warning for `model.NameValidationScheme` * Remove outdated native histogram OOO integration test
machine424
pushed a commit
to machine424/prometheus
that referenced
this pull request
Mar 26, 2025
…theus#16199) promql: return NaN from `irate()` if either of last two samples is NaN Signed-off-by: Charles Korn <[email protected]> --------- Signed-off-by: Charles Korn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in #15853 that causes
irate()to return a non-NaN value if the second-last point is a NaN but the last point is not.In this case, then
irate()would ignore the NaN and compute the rate as if a counter reset occurred before the last point.