Skip to content

[EXPERIMENT] Prombench metadata-wal-records feature#15907

Closed
bwplotka wants to merge 1 commit intomainfrom
bwplotka-patch-3
Closed

[EXPERIMENT] Prombench metadata-wal-records feature#15907
bwplotka wants to merge 1 commit intomainfrom
bwplotka-patch-3

Conversation

@bwplotka
Copy link
Copy Markdown
Member

Just for prombench.

@bwplotka
Copy link
Copy Markdown
Member Author

/prombench main --bench.version=bench/on-and-off-same-prom-version/metadata-wal-records

@prombot
Copy link
Copy Markdown
Contributor

prombot commented Jan 30, 2025

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-15907 and main

Custom benchmark version: bench/on-and-off-same-prom-version/metadata-wal-records branch

After the successful deployment (check status here), the benchmarking results can be viewed at:

Available Commands:

  • To restart benchmark: /prombench restart main --bench.version=bench/on-and-off-same-prom-version/metadata-wal-records
  • To stop benchmark: /prombench cancel
  • To print help: /prombench help

@bwplotka
Copy link
Copy Markdown
Member Author

/prombench restart main --bench.version=bench/on-and-off-same-prom-version/metadata-wal-records

@prombot
Copy link
Copy Markdown
Contributor

prombot commented Jan 30, 2025

⏱️ Welcome (again) to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-15907 and main

Custom benchmark version: bench/on-and-off-same-prom-version/metadata-wal-records branch

After successful deployment (check status here), the benchmarking results can be viewed at:

Available Commands:

  • To restart benchmark: /prombench restart main --bench.version=bench/on-and-off-same-prom-version/metadata-wal-records
  • To stop benchmark: /prombench cancel
  • To print help: /prombench help

@bwplotka
Copy link
Copy Markdown
Member Author

/prombench restart main --bench.version=bench/cross-feature/metadata-wal-records

@prombot
Copy link
Copy Markdown
Contributor

prombot commented Jan 30, 2025

⏱️ Welcome (again) to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-15907 and main

Custom benchmark version: bench/cross-feature/metadata-wal-records branch

After successful deployment (check status here), the benchmarking results can be viewed at:

Available Commands:

  • To restart benchmark: /prombench restart main --bench.version=bench/cross-feature/metadata-wal-records
  • To stop benchmark: /prombench cancel
  • To print help: /prombench help

@bwplotka bwplotka changed the title [DO NOT MERGE] Prombench metadata-wal-records feature [EXPERIMENT] Prombench metadata-wal-records feature Jan 30, 2025
@bwplotka
Copy link
Copy Markdown
Member Author

/prombench main --bench.version=bench/cross-feature/metadata-wal-records

@prombot
Copy link
Copy Markdown
Contributor

prombot commented Jan 30, 2025

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-15907 and main

Custom benchmark version: bench/cross-feature/metadata-wal-records branch

After the successful deployment (check status here), the benchmarking results can be viewed at:

Available Commands:

  • To restart benchmark: /prombench restart main --bench.version=bench/cross-feature/metadata-wal-records
  • To stop benchmark: /prombench cancel
  • To print help: /prombench help

@bwplotka
Copy link
Copy Markdown
Member Author

/prombench main --bench.version=bench/cross-feature/metadata-wal-records

@prombot
Copy link
Copy Markdown
Contributor

prombot commented Jan 30, 2025

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-15907 and main

Custom benchmark version: bench/cross-feature/metadata-wal-records branch

After the successful deployment (check status here), the benchmarking results can be viewed at:

Available Commands:

  • To restart benchmark: /prombench restart main --bench.version=bench/cross-feature/metadata-wal-records
  • To stop benchmark: /prombench cancel
  • To print help: /prombench help

@bwplotka
Copy link
Copy Markdown
Member Author

Deleting manually both Prometheus pods to test restarts too. Will add separate proposal for automation for that on prombench.

@bwplotka
Copy link
Copy Markdown
Member Author

bwplotka commented Jan 31, 2025

So there is an increase in memory (below 3 GB more RSS, sometimes 4GB more of heap allocs) when you enable metadata-wal-records. This is somewhat expected as we now track metadata per series, but maybe not to that degree.

Is it acceptable? Who knows, the lower the better. One alternative is the @dashpole proposal which could replace this feature (not for help though): prometheus/proposals#39

image

image

Heap profile: heap.mem.pprof.gz

@bwplotka
Copy link
Copy Markdown
Member Author

I see some metadata work increase for loadWAL (I assume after restart operation).

heap.mem.pprof.gz

But nothing in inuse for metadata directly 🤔

@bwplotka
Copy link
Copy Markdown
Member Author

There are some massive mem spikes

image

Looking on profile again, it's actually no only WAL load but also compaction (checkpoint logic)

image

@bwplotka
Copy link
Copy Markdown
Member Author

This does not explain 14% of constant RSS increase and 30% heap increase, though.

@bwplotka
Copy link
Copy Markdown
Member Author

Create issue for it #15911 closing this experiment for now.

@bwplotka
Copy link
Copy Markdown
Member Author

/prombench cancel

@bwplotka bwplotka closed this Jan 31, 2025
@prombot
Copy link
Copy Markdown
Contributor

prombot commented Jan 31, 2025

Benchmark cancel is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants