OTLP receiver: Return to using stdlib for splitting metric name in classical translation mode#15573
Merged
aknuds1 merged 1 commit intoprometheus:mainfrom Dec 11, 2024
Merged
Conversation
In non-UTF-8 mode, use strings.FieldsFunc to split string into tokens, as it was before PR prometheus#15258. This makes the code more robust and readable. Signed-off-by: Arve Knudsen <[email protected]>
ArthurSens
approved these changes
Dec 11, 2024
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
Can we remove the file helpers_from_stdlib.go now that they aren't used?
Contributor
Author
We can't yet, since the functions in the file are still used for UTF-8 translation mode (I just stopped using them for the classical translation mode). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the OTLP receiver's non-UTF-8 translation mode (i.e.
UnderscoreEscapingWithSuffixes), usestrings.FieldsFuncto split string into tokens, to return to how it was before #15258. This makes the code more robust and readable, since there's no need for a custom version ofstrings.FieldsFunc.This is preparing for the consensus on #15440.