promql: Fix various UTF-8 bugs related to quoting#15531
Merged
Conversation
ywwg
force-pushed
the
owilliams/promqltest
branch
3 times, most recently
from
0bf137e to
4c0486c
Compare
bboreham
reviewed
Dec 3, 2024
bboreham
reviewed
Dec 3, 2024
ywwg
force-pushed
the
owilliams/promqltest
branch
from
d0d65ca to
3a217d4
Compare
ywwg
force-pushed
the
owilliams/promqltest
branch
2 times, most recently
from
4b7581b to
e6317ef
Compare
Member
Author
|
any ideas why my TestParseSeriesDesc test is failing on CI but not on my machine? I have Go 1.23.3 locally |
Member
Author
|
ok I can get it to fail with --tags=dedupelabels |
Member
Author
|
ok it's probably because label equality is not the right way to test |
ywwg
force-pushed
the
owilliams/promqltest
branch
from
e6317ef to
2d74843
Compare
bboreham
reviewed
Dec 4, 2024
Member
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Some suggestions below.
Title needs expanding to cover all changes. (Or split into multiple PRs)
Why does the parser change?
ywwg
changed the title
Member
Author
the parser change is the second item -- quoted metric names were not supported in the "series description" path, which is separate from the vector selector path that had been updated. |
ywwg
force-pushed
the
owilliams/promqltest
branch
4 times, most recently
from
c2e47fe to
5ddeefc
Compare
Fixes UTF-8 aggregator label list items getting mutated with quote marks when String-ified. Fixes quoted metric names not supported in metric declarations. Fixes UTF-8 label names not being quoted when String-ified. Fixes #15470 Fixes #15528 Signed-off-by: Owen Williams <[email protected]> Co-authored-by: Bryan Boreham <[email protected]>
ywwg
force-pushed
the
owilliams/promqltest
branch
from
5ddeefc to
8d4bcd2
Compare
beorn7
approved these changes
Dec 10, 2024
17 tasks
This was referenced Dec 19, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UTF-8 aggregator label list items getting mutated with quote marks when String-ified.
Fixes quoted metric names not supported in metric declarations.
Fixes UTF-8 label names not being quoted when String-ified.
Fixes #15470
Fixes #15528