3.0 Port: Allow UTF-8 characters in metric and label names as opt-in feature (plus config entry)#15384
Merged
bwplotka merged 2 commits intorelease-3.0from Nov 11, 2024
Merged
Conversation
…15258) * Allow UTF-8 characters in metric and label names as opt-in feature --------- Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: bwplotka <[email protected]>
bwplotka
requested review from
aknuds1,
cstyan,
jesusvazquez and
tomwilkie
as code owners
bwplotka
commented
Nov 11, 2024
| # - "NoUTF8EscapingWithSuffixes" is a mode that relies on UTF-8 support in Prometheus. | ||
| # It preserves all special characters like dots, but it still add required suffixes | ||
| # for units and _total like in UnderscoreEscapingWithSuffixes. | ||
| [ translation_strategy: <string> | default = "UnderscoreEscapingWithSuffixes" ] |
Member
Author
There was a problem hiding this comment.
FYI: Added this on top of your changes @ArthurSens
This was referenced Nov 11, 2024
ArthurSens
approved these changes
Nov 11, 2024
Member
Author
|
Tested internally, works great!
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main source of UTF traffic is from OTLP receiver. It's silly to enable UTF-8 by default but NOT allow OTLP receive to avoid normalization from e.g.
..For this reason I propose to port #15258 to 3.0 branch.
See https://cloud-native.slack.com/archives/C077Z4V13AM/p1731358488986449