bugfix: Fix otlp translator switching colons to underscores in suffix adding mode#15251
Merged
bugfix: Fix otlp translator switching colons to underscores in suffix adding mode#15251
Conversation
Signed-off-by: Arthur Silva Sens <[email protected]>
aknuds1
changed the title
aknuds1
changed the title
aknuds1
approved these changes
Nov 3, 2024
Contributor
aknuds1
left a comment
aknuds1
left a comment
There was a problem hiding this comment.
I noticed the same bug. Thanks!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15199
Colons are allowed in metric names even without UTF8 support. The usage of colons is a very common pattern for recording rules, as documented in our website and by PromLabs, and broadly used by popular mixins.
This bug only occurs in suffix adding mode, not otherwise. Note that this mode is hard coded in Prometheus itself, but can be disabled when using Prometheus as a library.