Rules: Refactor concurrency controller interface#14491
Merged
Conversation
Even though the main purpose of this refactor is to modify the interface of the concurrency controller to accept a Context. I did two drive-by modifications that I think are sensible: 1. I have moved the check for dependencies on rules to the controller itself - this aligns with how the controller should behave as it is a deciding factor on wether we should run concurrently or not. 2. I cleaned up some unused methods from the days of the old interface before #13527 changed it. Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
gotjosh
commented
Jul 19, 2024
…ler. Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
Member
Author
|
This doesn't change any functionality and is just a simple refactor - I'm going to merge for now but please do let me know if this there's something that I missed. |
jesusvazquez
approved these changes
Jul 22, 2024
Member
jesusvazquez
left a comment
jesusvazquez
left a comment
There was a problem hiding this comment.
LGTM!!
Not sure how widespread RuleConcurrencyController interface is but this change is modifying it. The contributor that makes the next release should probably add it to the changelog.
Member
Author
It's only used on an experimental feature and as far as I know not used yet by any downstream projects as it is relatively new. |
kushalShukla-web
pushed a commit
to kushalShukla-web/prometheus
that referenced
this pull request
Jul 23, 2024
* Rules: Refactor concurrency controller interface Even though the main purpose of this refactor is to modify the interface of the concurrency controller to accept a Context. I did two drive-by modifications that I think are sensible: 1. I have moved the check for dependencies on rules to the controller itself - this aligns with how the controller should behave as it is a deciding factor on wether we should run concurrently or not. 2. I cleaned up some unused methods from the days of the old interface before prometheus#13527 changed it. Signed-off-by: gotjosh <[email protected]> --------- Signed-off-by: gotjosh <[email protected]> Signed-off-by: kushagra Shukla <[email protected]>
kushalShukla-web
pushed a commit
to kushalShukla-web/prometheus
that referenced
this pull request
Jul 25, 2024
* Rules: Refactor concurrency controller interface Even though the main purpose of this refactor is to modify the interface of the concurrency controller to accept a Context. I did two drive-by modifications that I think are sensible: 1. I have moved the check for dependencies on rules to the controller itself - this aligns with how the controller should behave as it is a deciding factor on wether we should run concurrently or not. 2. I cleaned up some unused methods from the days of the old interface before prometheus#13527 changed it. Signed-off-by: gotjosh <[email protected]> --------- Signed-off-by: gotjosh <[email protected]>
kushalShukla-web
pushed a commit
to kushalShukla-web/prometheus
that referenced
this pull request
Jul 25, 2024
* Rules: Refactor concurrency controller interface Even though the main purpose of this refactor is to modify the interface of the concurrency controller to accept a Context. I did two drive-by modifications that I think are sensible: 1. I have moved the check for dependencies on rules to the controller itself - this aligns with how the controller should behave as it is a deciding factor on wether we should run concurrently or not. 2. I cleaned up some unused methods from the days of the old interface before prometheus#13527 changed it. Signed-off-by: gotjosh <[email protected]> --------- Signed-off-by: gotjosh <[email protected]> Signed-off-by: Kushal Shukla <[email protected]>
bboreham
pushed a commit
to bboreham/prometheus
that referenced
this pull request
Oct 22, 2024
…r-prometheus-b03b895 * upstream/main: [DOCS] Querying basics: explain range and instant queries Rules: Refactor concurrency controller interface (prometheus#14491) [PRW 2.0] Added Sender and RW Handler support for Response Stats. (prometheus#14444) docs: Correct and clarify histogram bucket and resolution limits OTLPConfig.UnmarshalYAML: Return error on invalid input Update for Docker deprecation Bump Otel semconv version to 1.26.0 Update Go dependencies Add otlptranslator tests Add to changelog Add config tests Sanitize configured OTel resource attributes promql: Add NHCB tests prometheusremotewrite: Support resource attribute promotion Update storage.md to provide right-sizing advice on retention TSDB: shrink memSeries by moving bools together ci: Add job to report build_all status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the main purpose of this refactor is to modify the interface of the concurrency controller to accept a Context. I did two drive-by modifications that I think are sensible: