Closed
Conversation
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
tesla59
requested review from
brancz,
bwplotka,
cstyan,
dgl,
jesusvazquez,
roidelapluie and
tomwilkie
as code owners
Member
|
OK, looks like #14091 excluded the string concatenation case mainly because there were so many instances of it. @tesla59 maybe there is an easy way to salvage this PR to handle all the string concatenation cases. I would recommend to get in touch with @alexandear to avoid working in parallel again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR enabled perfsprint linter and fixes all errors generated by it
fixes #13668