Enable perfsprint linter and fix up code issues#14091
Merged
beorn7 merged 1 commit intoprometheus:mainfrom May 15, 2024
alexandear:enable-perfsprint-linter
Merged
Enable perfsprint linter and fix up code issues#14091beorn7 merged 1 commit intoprometheus:mainfrom alexandear:enable-perfsprint-linter
beorn7 merged 1 commit intoprometheus:mainfrom
alexandear:enable-perfsprint-linter
Conversation
alexandear
requested review from
bwplotka,
cstyan,
dgl,
jesusvazquez,
roidelapluie and
tomwilkie
as code owners
This was referenced May 13, 2024
beorn7
requested changes
May 15, 2024
Member
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Looks good, just wondering about the text entry in .golangci.yml.
Signed-off-by: Oleksandr Redko <[email protected]>
beorn7
approved these changes
May 15, 2024
Member
|
Thanks @alexandear for this and @beorn7 for the review. |
This was referenced May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables perfsprint linter and fixes its issues.
Changes that improve both readability and performance are:
fmt.Sprintf("%d", x),fmt.Sprint(x)withstrconv.Itoa(x)for int values;fmt.Sprintf("%t", b)withstrconv.FormatBool(b)for bool values;fmt.Sprintf("%d", x)withstrconv.FormatIntfor int64 values;fmt.Sprintf("%d", x)withstrconv.FormatUintfor uint64 values;fmt.Sprintstatements.