bugfix: Decouple native histogram ingestions and protobuf parsing#13987
bugfix: Decouple native histogram ingestions and protobuf parsing#13987ArthurSens merged 1 commit intomainfrom
Conversation
|
I've tested the fix locally, the error does disappear, now for the review. |
krajorama
left a comment
krajorama
left a comment
There was a problem hiding this comment.
Looks good, two nit comments
Up until this point, if a scrape was done with the protobuf format Prometheus would always try to ingest native histograms even with the feature flag disabled. This causes problems with other feature-flags that depend on the protobuf format, like 'created-timestamp-zero-ingestion'. This commit decouples native histogram parsing from ingestion, making sure ingestion only happens when the 'native-histogram' feature-flag is enabled. Signed-off-by: Arthur Silva Sens <[email protected]>
ArthurSens
force-pushed
the
nativeHis-flag-ingestion
branch
from
3d25789 to
7aacef9
Compare
|
Thanks, fixed the two comments :) I wonder if the base branch should be |
The bug concerns experimental features and has a workaround, so I'm personally ok with either. On the other hand 2.53 is pretty far away so it makes sense to do it on 2.52 |
I'll leave it for 2.53 because the release process started a few days ago already 😬 |
2 participants
Up until this point, if a scrape was done with the protobuf format Prometheus would always try to ingest native histograms even with the feature flag disabled. This causes problems with other feature-flags that depend on the protobuf format, like 'created-timestamp-zero-ingestion'. This commit decouples native histogram parsing from ingestion, making sure ingestion only happens when the 'native-histogram' feature-flag is enabled.
Fix #13920