Adds Inf and NaN as Numbers to Histogram in Promql Testing Framework#13916
Merged
beorn7 merged 3 commits intoprometheus:mainfrom Apr 11, 2024
Merged
Adds Inf and NaN as Numbers to Histogram in Promql Testing Framework#13916beorn7 merged 3 commits intoprometheus:mainfrom
beorn7 merged 3 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Neeraj Gartia <[email protected]>
beorn7
approved these changes
Apr 11, 2024
Member
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Thank you very much.
I'm not an expert when it comes to the lexer, but I assume this is the way to go.
Note that generally, we try to use normal English syntax in comments. I will commit my nits directly, so no need for you to update this PR.
Signed-off-by: Björn Rabenstein <[email protected]>
Signed-off-by: Björn Rabenstein <[email protected]>
Contributor
Author
|
Thanks @beorn7 for merging it and I'll follow general english syntax from now on. |
bboreham
pushed a commit
to bboreham/prometheus
that referenced
this pull request
Jun 20, 2024
* upstream/main: (32 commits) Avoid creating new slices for labels values on postings for matchers (prometheus#13958) Improve the metric description Add a changelog entry Change variable name to `restoreStartTime` from `now` and introduce a log line to record total time promtool: Fix panic on extended tsdb analyze (prometheus#13976) Rule Manager: Add `rule_group_last_restore_duration_seconds` to measure restore time per rule group build(deps): bump github.com/aws/aws-sdk-go from 1.51.24 to 1.51.25 build(deps): bump github.com/hetznercloud/hcloud-go/v2 Downgrade github.com/ovh/go-ovh back to v1.4.3 Downgrade k8s apis back to v0.29.3 Update Go dependencies before 2.52 build(deps): bump github.com/prometheus/common tsdb/wlog: add test for metrics unregistering discovery(k8s): add metadata labels to endpointslices parser: remake generated_parser output (prometheus#13923) Adds Inf and NaN as Numbers to Histogram in Promql Testing Framework (prometheus#13916) tsdb/wlog: unregister metrics on WL close golangci-lint: enable whitespace linter (prometheus#13905) Cut release 2.51.2 List Prometheus v3 coordinators in MAINTAINERS.md ... Signed-off-by: gotjosh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Promql Testing Framework doesn't support
InfandNaNas numbers in histogram description such assumandcount. Descriptions like-sum: NaNandcount: Infresults in error and this PR fixes this issue.