Change discovery manager syncCh to buffered channel#13677
Closed
Spaceman1701 wants to merge 4 commits intoprometheus:mainfrom
Closed
Change discovery manager syncCh to buffered channel#13677Spaceman1701 wants to merge 4 commits intoprometheus:mainfrom
Spaceman1701 wants to merge 4 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Ethan Hunter <[email protected]>
Signed-off-by: Ethan Hunter <[email protected]>
Contributor
Author
|
I've updated this so it buffers both the new discovery manager and the legacy discovery manager since they both seem to have the same problem. |
Signed-off-by: Ethan Hunter <[email protected]>
Member
jesusvazquez
left a comment
jesusvazquez
left a comment
There was a problem hiding this comment.
Thank you for raising and looking at this issue.
For future reviewers, most of the conversation around this PR is happening in the issue linked. We left a comment there #13676 (comment)
…h buffered channel
Member
|
Hello from the bug scrub! Looks like #14174 fixed it already. If there's anything else to do let us know on Slack or separate issue, thanks! 💪🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to improve the behavior of Alertmanager service discovery when the notifier is under high load. In normal conditions, buffering this channel doesn't make much of a difference as both the discovery manager and the receiver have plenty of chances to write/read the channel. When the receiver is under heavy load, the buffered channel guarantees it will see the results of a recent discovery manager iteration. I don't think this has any unforeseen impacts. I've opened #13676 with details of the problem I'm trying to fix.
Fixes #13676