Skip to content

MemPostings: Use CockroachDB Swiss Map for label values/postings map#13646

Closed
aknuds1 wants to merge 1 commit intoprometheus:mainfrom
aknuds1:arve/mempostings-cockroachdb-swissmap
Closed

MemPostings: Use CockroachDB Swiss Map for label values/postings map#13646
aknuds1 wants to merge 1 commit intoprometheus:mainfrom
aknuds1:arve/mempostings-cockroachdb-swissmap

Conversation

@aknuds1
Copy link
Copy Markdown
Contributor

@aknuds1 aknuds1 commented Feb 26, 2024

Test of CockroachDB Swiss Map instead of standard map in tsdb/index.MemPostings, for performance. Requested by @bboreham for prombench-ing, so we can see if there's any real difference.

Confer corresponding PR for dolthub implementation.

@bboreham
Copy link
Copy Markdown
Member

/prombench main

@prombot
Copy link
Copy Markdown
Contributor

prombot commented Feb 26, 2024

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-13646 and main

After successful deployment, the benchmarking results can be viewed at:

Other Commands:
To stop benchmark: /prombench cancel
To restart benchmark: /prombench restart main

@bboreham
Copy link
Copy Markdown
Member

On these metrics, this one is substantially worse. However I can't see the swiss.Map in a CPU profile so unclear what this is telling us.

image

@bboreham
Copy link
Copy Markdown
Member

/prombench restart

@prombot
Copy link
Copy Markdown
Contributor

prombot commented Feb 26, 2024

Incorrect prombench syntax, please find correct syntax here.

@bboreham
Copy link
Copy Markdown
Member

/prombench restart main

@prombot
Copy link
Copy Markdown
Contributor

prombot commented Feb 26, 2024

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-13646 and main

After successful deployment, the benchmarking results can be viewed at:

Other Commands:
To stop benchmark: /prombench cancel
To restart benchmark: /prombench restart main

@aknuds1 aknuds1 force-pushed the arve/mempostings-cockroachdb-swissmap branch from 069f99c to f4e8851 Compare February 26, 2024 15:59
@bboreham
Copy link
Copy Markdown
Member

/prombench cancel

@prombot
Copy link
Copy Markdown
Contributor

prombot commented Feb 29, 2024

Benchmark cancel is in progress.

@aknuds1
Copy link
Copy Markdown
Contributor Author

aknuds1 commented Mar 4, 2024

Closing since outlived its usefulness.

@aknuds1 aknuds1 closed this Mar 4, 2024
@aknuds1 aknuds1 deleted the arve/mempostings-cockroachdb-swissmap branch March 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants