MemPostings: Use dolthub SwissMap for label values/postings map#13644
Closed
aknuds1 wants to merge 1 commit intoprometheus:mainfrom
Closed
MemPostings: Use dolthub SwissMap for label values/postings map#13644aknuds1 wants to merge 1 commit intoprometheus:mainfrom
aknuds1 wants to merge 1 commit intoprometheus:mainfrom
Conversation
Member
|
/prombench main |
This was referenced Feb 26, 2024
Member
|
No material difference observed. 
|
Contributor
Author
|
@bboreham isn't there a noticeable difference Avg HTTP request latency (especially /api/v1/query_range)? Also HTTP request/s for the same endpoint (/api/v1/query_range). |
Member
|
Yeah if you can explain why the endpoint varies when the time to evaluate doesn't. |
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/mempostings-dolthub-swissmap
branch
from
c2ba4c5 to
c69ed1a
Compare
Member
|
The difference in http latency measurement has disappeared. |
Member
|
/prombench cancel |
1 similar comment
Member
|
/prombench cancel |
Contributor
|
Benchmark cancel is in progress. |
1 similar comment
Contributor
|
Benchmark cancel is in progress. |
Contributor
Author
|
Closing since outlived its usefulness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test of dolthub SwissMap instead of standard
mapintsdb/index.MemPostings, for performance. Requested by @bboreham for prombench-ing, so we can see if there's any real difference.Confer corresponding PR for CockroachDB implementation.