tsdb/wlog: small cleanup of WAL watcher after #13583#13628
Merged
bboreham merged 3 commits intoprometheus:mainfrom Feb 23, 2024
Merged
tsdb/wlog: small cleanup of WAL watcher after #13583#13628bboreham merged 3 commits intoprometheus:mainfrom
bboreham merged 3 commits intoprometheus:mainfrom
Conversation
Sleep() is documented to return immediately on negative or zero input. Signed-off-by: Bryan Boreham <[email protected]>
Print lastSegment after it gets initialized. Move variable declaration to first use. Signed-off-by: Bryan Boreham <[email protected]>
Clarify in the first comment that it is `watch()` that waits, and reduce verbiage. The second comment was slightly contradictory to the first and otherwise didn't seem to add much, since `currentSegment` was incremented just a few lines later. Signed-off-by: Bryan Boreham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sleep()is documented to return immediately on negative or zero input.lastSegmentafter it gets initialized, move variable declaration to first use.watch()that waits, and reduce verbiage.didn't seem to add much, since
currentSegmentwas incremented just afew lines later.