ci(lint): enable errorlint linter on cmd#12898
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Sep 29, 2023
mmorel-35:lint/errorlint
Merged
ci(lint): enable errorlint linter on cmd#12898roidelapluie merged 1 commit intoprometheus:mainfrom mmorel-35:lint/errorlint
roidelapluie merged 1 commit intoprometheus:mainfrom
mmorel-35:lint/errorlint
Conversation
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
commented
Sep 28, 2023
| - name: Install Go | ||
| uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 | ||
| with: | ||
| cache: false |
Contributor
Author
There was a problem hiding this comment.
There is another cache handled by golangci-lint. This avoid errors when they both try to retrieve their contents.
Member
There was a problem hiding this comment.
We could have that in a comment in the yaml file.
Member
|
Thanks! |
This was referenced Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables errorlint on cmd package and disables it for discovery, model, scrape, storage, tsdb, util, web folders.
It will help to apply it step by step.
Signed-off-by: Matthieu MOREL [email protected]