Add Exemplars support for all time series#11984
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Mar 5, 2023
Merged
Conversation
bboreham
reviewed
Mar 1, 2023
Member
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Thanks! Code seems ok; couple of queries about changes to tests.
roidelapluie
approved these changes
Mar 4, 2023
jonatan-ivanov
force-pushed
the
exemplars-for-all-time-series
branch
from
bf6f342 to
7bd45f2
Compare
This change removes restrictions to allow adding exemplars to all time series. It also contains some improvements in test values so that it is easier to track what is tested. The advantage of doing this is having a little less error-prone tests: "yy" is not really descriptive but "counter-test" can give people a better idea about what is tested so it is harder to make mistakes. Closes prometheusgh-11982 Signed-off-by: Jonatan Ivanov <[email protected]>
jonatan-ivanov
force-pushed
the
exemplars-for-all-time-series
branch
from
7bd45f2 to
9225d11
Compare
Member
|
Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11982