ci: add minimum GitHub token permissions for workflows#11285
Merged
roidelapluie merged 2 commits intoprometheus:mainfrom Jul 18, 2023
Merged
ci: add minimum GitHub token permissions for workflows#11285roidelapluie merged 2 commits intoprometheus:mainfrom
roidelapluie merged 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Ashish Kurmi <[email protected]>
hoffie
reviewed
Sep 12, 2022
Co-authored-by: Christian Hoffmann <[email protected]> Signed-off-by: Ashish Kurmi <[email protected]>
Contributor
Author
|
Thanks for flagging the gap @hoffie! I have incorporated your requested change, please take a look again. |
Contributor
Looks good to me, but I don't feel confident commenting on the other actions. ;) |
roidelapluie
approved these changes
Jul 18, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds minimum token permissions for the GITHUB_TOKEN in GitHub Actions workflows using https://github.com/step-security/secure-workflows.
GitHub Actions workflows have a GITHUB_TOKEN with write access to multiple scopes.
Here is an example of the permissions in one of the workflows:
https://github.com/prometheus/prometheus/runs/8238094120?check_suite_focus=true#step:1:19
The 'Lock Threads' workflow already has the minimum token permission set. After this change, the scopes will be reduced to the minimum needed for other workflows.
Motivation and Context
Signed-off-by: Ashish Kurmi [email protected]