Split notifier select in 2 to ensure newer targets are used.#10948
Merged
roidelapluie merged 3 commits intoprometheus:mainfrom Jul 1, 2022
Merged
Split notifier select in 2 to ensure newer targets are used.#10948roidelapluie merged 3 commits intoprometheus:mainfrom
roidelapluie merged 3 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
force-pushed
the
notifierselect
branch
from
2104ef2 to
0301957
Compare
Member
Author
|
My last push was only gofumpt, so I'll go ahead and auto merge this. |
Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
force-pushed
the
notifierselect
branch
from
0301957 to
0a5b7ad
Compare
Member
Author
|
@SuperQ can you review again? I removed the flakiness by running the test 10 times with timeoutes 10 limes lower (so it is still pretty fast). |
Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
force-pushed
the
notifierselect
branch
from
d7b89dd to
8569532
Compare
machine424
added a commit
to machine424/prometheus
that referenced
this pull request
Jun 3, 2024
to show "targets groups update" starvation when the notifications queue is full and an Alertmanager is down. The existing `TestHangingNotifier` that was added in prometheus#10948 doesn't really reflect the reality as the SD changes are manually fed into `syncCh` in a continuous way, whereas in reality, updates are only resent every `updatert`. The test added here sets up an SD manager and links it to the notifier. The SD changes will be triggered by that manager as it's done in reality. Signed-off-by: machine424 <[email protected]> Co-authored-by: Ethan Hunter <[email protected]> test: use atomic to prevent races.
machine424
added a commit
to machine424/prometheus
that referenced
this pull request
Jun 3, 2024
to show "targets groups update" starvation when the notifications queue is full and an Alertmanager is down. The existing `TestHangingNotifier` that was added in prometheus#10948 doesn't really reflect the reality as the SD changes are manually fed into `syncCh` in a continuous way, whereas in reality, updates are only resent every `updatert`. The test added here sets up an SD manager and links it to the notifier. The SD changes will be triggered by that manager as it's done in reality. Signed-off-by: machine424 <[email protected]> Co-authored-by: Ethan Hunter <[email protected]>
machine424
added a commit
to machine424/prometheus
that referenced
this pull request
Jun 10, 2024
to show "targets groups update" starvation when the notifications queue is full and an Alertmanager is down. The existing `TestHangingNotifier` that was added in prometheus#10948 doesn't really reflect the reality as the SD changes are manually fed into `syncCh` in a continuous way, whereas in reality, updates are only resent every `updatert`. The test added here sets up an SD manager and links it to the notifier. The SD changes will be triggered by that manager as it's done in reality. Signed-off-by: machine424 <[email protected]> Co-authored-by: Ethan Hunter <[email protected]>
machine424
added a commit
to machine424/prometheus
that referenced
this pull request
Jun 19, 2024
to show "targets groups update" starvation when the notifications queue is full and an Alertmanager is down. The existing `TestHangingNotifier` that was added in prometheus#10948 doesn't really reflect the reality as the SD changes are manually fed into `syncCh` in a continuous way, whereas in reality, updates are only resent every `updatert`. The test added here sets up an SD manager and links it to the notifier. The SD changes will be triggered by that manager as it's done in reality. Signed-off-by: machine424 <[email protected]> Co-authored-by: Ethan Hunter <[email protected]>
machine424
added a commit
that referenced
this pull request
Jun 19, 2024
to show "targets groups update" starvation when the notifications queue is full and an Alertmanager is down. The existing `TestHangingNotifier` that was added in #10948 doesn't really reflect the reality as the SD changes are manually fed into `syncCh` in a continuous way, whereas in reality, updates are only resent every `updatert`. The test added here sets up an SD manager and links it to the notifier. The SD changes will be triggered by that manager as it's done in reality. Signed-off-by: machine424 <[email protected]> Co-authored-by: Ethan Hunter <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8768
Signed-off-by: Julien Pivotto [email protected]