Skip to content

[meta] AppendV2 flaky tests #17941

@bwplotka

Description

@bwplotka

Collection of flaky tests to fix, potentially introduced (or elevated) by AppenderV2 work:

  • (windows) TestQuerierShouldNotFailIfOOOCompactionOccursAfterRetrievingQuerier_AppendV2 and TestQuerierShouldNotFailIfOOOCompactionOccursAfterRetrievingIterators_AppendV2
Image
  • TestHeadAppenderV2_HighConcurrencyReadAndWrite
head_append_v2_test.go:257: 
        	Error Trace:	/__w/prometheus/prometheus/tsdb/head_append_v2_test.go:257
        	Error:      	Received unexpected error:
        	            	Error when appending to head: out of bounds
        	Test:       	TestHeadAppenderV2_HighConcurrencyReadAndWrite
  • TestWaitForPendingReadersInTimeRange_AppenderV2

https://github.com/prometheus/prometheus/actions/runs/21475807050/job/61859418374?pr=17967

--- FAIL: TestWaitForPendingReadersInTimeRange_AppenderV2 (13.33s)
    --- FAIL: TestWaitForPendingReadersInTimeRange_AppenderV2/mint=1800,maxt=2500,shouldWait=true (2.23s)
        head_append_v2_test.go:1638: 
            	Error Trace:	/__w/prometheus/prometheus/tsdb/head_append_v2_test.go:1638
            	            				/__w/prometheus/prometheus/tsdb/head_append_v2_test.go:1647
            	Error:      	Should be true
            	Test:       	TestWaitForPendingReadersInTimeRange_AppenderV2/mint=1800,maxt=2500,shouldWait=true
  • github.com/prometheus/prometheus/scrape

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x152f3b9]

goroutine 525 [running]:
github.com/prometheus/prometheus/scrape.(*scrapeLoop).appender(0xc0000fc180)
	/__w/prometheus/prometheus/scrape/scrape.go:1314 +0x199
github.com/prometheus/prometheus/scrape.(*scrapeLoop).scrapeAndReport(0xc0000fc180, {0xee10a74c3?, 0x23b1d60?, 0x0?}, {0xee10a74c3?, 0x23b1d60?, 0x23b1d60?}, 0x0)
	/__w/prometheus/prometheus/scrape/scrape.go:1338 +0x4ea
github.com/prometheus/prometheus/scrape.(*scrapeLoop).run(0xc0000fc180, 0x0)
	/__w/prometheus/prometheus/scrape/scrape.go:1291 +0x5ad
github.com/prometheus/prometheus/scrape.(*scrapePool).restartLoops.func1({0x1b27918, 0xc000398000}, {0x1b27918, 0xc0000fc180})
	/__w/prometheus/prometheus/scrape/scrape.go:368 +0xc6
created by github.com/prometheus/prometheus/scrape.(*scrapePool).restartLoops in goroutine 524
	/__w/prometheus/prometheus/scrape/scrape.go:362 +0xd53
FAIL	github.com/prometheus/prometheus/scrape	0.379s
  • TestDiskFillingUpAfterDisablingOOO_AppendV2
panic: test timed out after 10m0s
	running tests:
		TestDiskFillingUpAfterDisablingOOO_AppendV2/custom_buckets_int_histogram (8m37s)
		TestDiskFillingUpAfterDisablingOOO_AppendV2/float (8m36s)
		TestDiskFillingUpAfterDisablingOOO_AppendV2/float_histogram (8m37s)
		TestDiskFillingUpAfterDisablingOOO_AppendV2/integer_histogram (8m36s)

goroutine 38123 [running]:
testing.(*M).startAlarm.func1()
	/usr/local/go/src/testing/testing.go:2682 +0x371
created by time.goFunc
	/usr/local/go/src/time/sleep.go:215 +0x2f

goroutine 1 [chan receive, 8 minutes]:
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1891 +0x53b
testing.tRunner(0xb6886c8, 0xb4d9d50)
	/usr/local/go/src/testing/testing.go:1940 +0x14a
testing.runTests(0xb68cee0, {0x98ed140, 0x181, 0x181}, {0xc2583967129c7185, 0x8bb33eda43, 0x98f1560})
	/usr/local/go/src/testing/testing.go:2475 +0x3ea
testing.(*M).Run(0xb695130)
	/usr/local/go/src/testing/testing.go:2337 +0x63a
go.uber.org/goleak.VerifyTestMain({0x9127dd0, 0xb695130}, {0xb523f2c, 0x3, 0x3})
	/go/pkg/mod/go.uber.org/[email protected]/testmain.go:53 +0x37
github.com/prometheus/prometheus/tsdb.TestMain(0xb695130)
	/__w/prometheus/prometheus/tsdb/db_test.go:78 +0x25a
main.main()
	_testmain.go:879 +0xe9

goroutine 35588 [chan receive, 8 minutes]:
testing.(*testState).waitParallel(0xb6dd340)
	/usr/local/go/src/testing/testing.go:2116 +0x72
testing.(*T).Parallel(0x1a281328)
	/usr/local/go/src/testing/testing.go:1709 +0x28e
github.com/prometheus/prometheus/tsdb.testDiskFillingUpAfterDisablingOOO(0x1a281328, {{0x8f19a4a, 0x9}, 0x8f764b0, 0x8f764b4})
	/__w/prometheus/prometheus/tsdb/db_test.go:8315 +0x32
github.com/prometheus/prometheus/tsdb.TestDiskFillingUpAfterDisablingOOO.func1(0x1a281328)
	/__w/prometheus/prometheus/tsdb/db_test.go:8309 +0x3d
testing.tRunner(0x1a281328, 0x1f0460f0)
	/usr/local/go/src/testing/testing.go:1934 +0x114
created by testing.(*T).Run in goroutine 14827
	/usr/local/go/src/testing/testing.go:1997 +0x4b4

goroutine 38102 [select, 8 minutes]:
github.com/prometheus/prometheus/tsdb/wlog.(*WL).run(0x760e34a0)
	/__w/prometheus/prometheus/tsdb/wlog/wlog.go:383 +0xa6
created by github.com/prometheus/prometheus/tsdb/wlog.NewSize in goroutine 30887
	/__w/prometheus/prometheus/tsdb/wlog/wlog.go:348 +0x440

goroutine 33427 [chan receive, 8 minutes]:
testing.(*testState).waitParallel(0xb6dd340)
	/usr/local/go/src/testing/testing.go:2116 +0x72
testing.(*T).Parallel(0xd4c8908)
	/usr/local/go/src/testing/testing.go:1709 +0x28e
github.com/prometheus/prometheus/tsdb.testOOOCompactionWithDisabledWriteLogAppend2(0xd4c8908, {{0x8f19a4a, 0x9}, 0x8f764d4, 0x8f764d8})
	/__w/prometheus/prometheus/tsdb/db_append_v2_test.go:4078 +0x32
github.com/prometheus/prometheus/tsdb.TestOOOCompactionWithDisabledWriteLog_AppendV2.func1(0xd4c8908)
	/__w/prometheus/prometheus/tsdb/db_append_v2_test.go:4072 +0x3d
testing.tRunner(0xd4c8908, 0x10567320)
	/usr/local/go/src/testing/testing.go:1934 +0x114
created by testing.(*T).Run in goroutine 1392
	/usr/local/go/src/testing/testing.go:1997 +0x4b4

goroutine 1391 [chan receive, 8 minutes]:
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1891 +0x53b
testing.tRunner(0xcb11d48, 0x8f75ca0)
	/usr/local/go/src/testing/testing.go:1940 +0x14a
created by testing.(*T).Run in goroutine 1
	/usr/local/go/src/testing/testing.go:1997 +0x4b4

goroutine 35590 [chan receive, 8 minutes]:
testing.(*testState).waitParallel(0xb6dd340)
	/usr/local/go/src/testing/testing.go:2116 +0x72
testing.(*T).Parallel(0x1a281568)
	/usr/local/go/src/testing/testing.go:1709 +0x28e
github.com/prometheus/prometheus/tsdb.testDiskFillingUpAfterDisablingOOO(0x1a281568, {{0x8f14f4c, 0x5}, 0x8f764a8, 0x8f764c0})
	/__w/prometheus/prometheus/tsdb/db_test.go:8315 +0x32
github.com/prometheus/prometheus/tsdb.TestDiskFillingUpAfterDisablingOOO.func1(0x1a281568)
	/__w/prometheus/prometheus/tsdb/db_test.go:8309 +0x3d
testing.tRunner(0x1a281568, 0x1f046180)
	/usr/local/go/src/testing/testing.go:1934 +0x114
created by testing.(*T).Run in goroutine 14827
	/usr/local/go/src/testing/testing.go:1997 +0x4b4

goroutine 1392 [chan receive, 8 minutes]:
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1891 +0x53b
testing.tRunner(0xcb11e68, 0x8f75c98)
	/usr/local/go/src/testing/testing.go:1940 +0x14a
created by testing.(*T).Run in goroutine 1
	/usr/local/go/src/testing/testing.go:1997 +0x4b4

goroutine 250 [chan receive, 8 minutes]:
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1891 +0x53b
testing.tRunner(0xb6898c8, 0x8f75a0c)
	/usr/local/go/src/testing/testing.go:1940 +0x14a
created by testing.(*T).Run in goroutine 1
	/usr/local/go/src/testing/testing.go:1997 +0x4b4

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions