-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Get rid of the EncOOOXOR from the chunk encodings #11835
Copy link
Copy link
Closed
Description
Proposal
EncOOOXOR was added as part of OOO support to indicate that this chunk, while XOR encoded, belongs to the OOO part of the Head block. This is used only in the ChunkDiskMapper when m-mapping so that when Prometheus restarts we can identify which chunks belong to the OOO Head.
Since this is not a new encoding, we should simplify this and remove EncOOOXOR, and instead do the same bit in ChunkDiskMapper itself to identify OOO chunks. This will also simplify things when we have OOO support for native histograms.
This won't be a breaking change because the same bit will be set to 1 in the ChunkDiskMapper; it is just how we do it is changing.
This issue is broken down from #11329
Reactions are currently unavailable